fix: update comments from pr

Author: k11kirky

llm_observability_examples.py

@@ -21,7 +21,6 @@
     posthog_client=posthog,
 )
 
-
 def main_sync():
     trace_id = str(uuid.uuid4())
     print("Trace ID:", trace_id)
@@ -90,6 +89,7 @@ async def basic_async_openai_call(distinct_id, trace_id, properties):
 
 
 def streaming_openai_call(distinct_id, trace_id, properties):
+    
     response = openai_client.chat.completions.create(
         model="gpt-4o-mini",
         messages=[
@@ -132,7 +132,7 @@ async def streaming_async_openai_call(distinct_id, trace_id, properties):
 
 
 def non_instrumented_openai_call():
-    response = openai_client.images.generate(model="dall-e-3", prompt="A cute baby sea otter", n=1, size="1024x1024")
+    response = openai_client.images.generate(model="dall-e-3", prompt="A cute baby hedgehog", n=1, size="1024x1024")
     print(response)
     return response
 

posthog/ai/providers/openai/openai.py

@@ -1,4 +1,5 @@
 import time
+import uuid
 from typing import Any, Dict, Optional, Union
 
 try:
@@ -66,7 +67,7 @@ def create(
         posthog_properties: Optional[Dict[str, Any]] = None,
         **kwargs: Any,
     ):
-        distinct_id = posthog_distinct_id or "anonymous_ai_user"
+        distinct_id = posthog_distinct_id or uuid.uuid4()
 
         if kwargs.get("stream", False):
             return self._create_streaming(
@@ -134,6 +135,8 @@ def _capture_streaming_event(
         latency: float,
         output: str,
     ):
+        if posthog_trace_id is None:
+            posthog_trace_id = uuid.uuid4()
 
         event_properties = {
             "$ai_provider": "openai",

posthog/ai/providers/openai/openai_async.py

@@ -1,4 +1,5 @@
 import time
+import uuid
 from typing import Any, Dict, Optional, Union
 
 try:
@@ -65,7 +66,7 @@ async def create(
         posthog_properties: Optional[Dict[str, Any]] = None,
         **kwargs: Any,
     ):
-        distinct_id = posthog_distinct_id or "anonymous_ai_user"
+        distinct_id = posthog_distinct_id or uuid.uuid4()
 
         # If streaming, handle streaming specifically
         if kwargs.get("stream", False):
@@ -130,6 +131,9 @@ def _capture_streaming_event(
         latency: float,
         output: str,
     ):
+        
+        if posthog_trace_id is None:
+            posthog_trace_id = uuid.uuid4()
 
         event_properties = {
             "$ai_provider": "openai",

posthog/ai/utils.py

@@ -1,4 +1,5 @@
 import time
+import uuid
 from typing import Any, Callable, Dict, Optional
 
 from posthog.client import Client as PostHogClient
@@ -62,11 +63,14 @@ def call_llm_and_track_usage(
         response = call_method(**kwargs)
     except Exception as exc:
         error = exc
-        http_status = getattr(exc, "status_code", 500)
+        http_status = getattr(exc, "status_code", 0) # default to 0 becuase its liekly an SDK error
     finally:
         end_time = time.time()
         latency = end_time - start_time
 
+        if posthog_trace_id is None:
+            posthog_trace_id = uuid.uuid4()
+
         if response and hasattr(response, "usage"):
             usage = response.usage.model_dump()
 
@@ -118,11 +122,14 @@ async def call_llm_and_track_usage_async(
         response = await call_async_method(**kwargs)
     except Exception as exc:
         error = exc
-        http_status = getattr(exc, "status_code", 500)
+        http_status = getattr(exc, "status_code", 0) # default to 0 because its likely an SDK error
     finally:
         end_time = time.time()
         latency = end_time - start_time
 
+        if posthog_trace_id is None:
+            posthog_trace_id = uuid.uuid4()
+
         if response and hasattr(response, "usage"):
             usage = response.usage.model_dump()