chore: Make condition_index optional. Also added some scripts for local dev. (#223)

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>

Author: haacked

bin/build

@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+#/ Usage: bin/build
+#/ Description: Runs linter and mypy
+source bin/helpers/_utils.sh
+set_source_and_root_dir
+
+flake8 posthog --ignore E501,W503
+mypy --no-site-packages --config-file mypy.ini . | mypy-baseline filter

bin/fmt

@@ -0,0 +1,13 @@
+#!/usr/bin/env bash
+#/ Usage: bin/fmt
+#/ Description: Formats and lints the code
+source bin/helpers/_utils.sh
+set_source_and_root_dir
+
+if [[ "$1" == "--check" ]]; then
+  black --check .
+  isort --check-only .
+else
+  black .
+  isort .
+fi

bin/helpers/_utils.sh

@@ -0,0 +1,15 @@
+error() {
+    echo "$@" >&2
+}
+
+fatal() {
+    error "$@"
+    exit 1
+}
+
+set_source_and_root_dir() {
+    { set +x; } 2>/dev/null
+    source_dir="$( cd -P "$( dirname "$0" )" >/dev/null 2>&1 && pwd )"
+    root_dir=$(cd "$source_dir" && cd ../ && pwd)
+    cd "$root_dir"
+}

bin/setup

@@ -0,0 +1,11 @@
+#!/usr/bin/env bash
+#/ Usage: bin/setup
+#/ Description: Sets up the dependencies needed to develop this project
+source bin/helpers/_utils.sh
+set_source_and_root_dir
+
+if [ ! -d "env" ]; then
+  python3 -m venv env
+fi
+source env/bin/activate
+pip install -e ".[dev,test]"

bin/test

@@ -0,0 +1,7 @@
+#!/usr/bin/env bash
+#/ Usage: bin/test
+#/ Description: Runs all the unit tests for this project
+source bin/helpers/_utils.sh
+set_source_and_root_dir
+
+pytest

posthog/test/test_feature_flags.py

@@ -2357,7 +2357,21 @@ def test_capture_is_called_with_flag_details(self, patch_flags, patch_capture):
                         "id": 23,
                         "version": 42,
                     },
-                }
+                },
+                "false-flag": {
+                    "key": "false-flag",
+                    "enabled": False,
+                    "variant": None,
+                    "reason": {
+                        "code": "no_matching_condition",
+                        "description": "No matching condition",
+                        "condition_index": None,
+                    },
+                    "metadata": {
+                        "id": 1,
+                        "version": 2,
+                    },
+                },
             },
             "requestId": "18043bf7-9cf6-44cd-b959-9662ee20d371",
         }

posthog/types.py

@@ -7,7 +7,7 @@
 @dataclass(frozen=True)
 class FlagReason:
     code: str
-    condition_index: int
+    condition_index: Optional[int]
     description: str
 
     @classmethod
@@ -16,7 +16,7 @@ def from_json(cls, resp: Any) -> Optional["FlagReason"]:
             return None
         return cls(
             code=resp.get("code", ""),
-            condition_index=resp.get("condition_index", 0),
+            condition_index=resp.get("condition_index"),
             description=resp.get("description", ""),
         )