Refactor requests exception imports through request.py

Export RequestsTimeout and RequestsConnectionError from posthog/request.py
to keep all requests library imports in one place and avoid mypy issues.

Author: haacked

posthog/client.py

@@ -37,13 +37,14 @@
     DEFAULT_HOST,
     APIError,
     QuotaLimitError,
+    RequestsConnectionError,
+    RequestsTimeout,
     batch_post,
     determine_server_host,
     flags,
     get,
     remote_config,
 )
-import requests.exceptions
 from posthog.contexts import (
     _get_current_context,
     get_context_distinct_id,
@@ -1597,10 +1598,10 @@ def _get_feature_flag_result(
             except QuotaLimitError as e:
                 self.log.exception(f"[FEATURE FLAGS] Quota limit exceeded: {e}")
                 feature_flag_error = "quota_limited"
-            except requests.exceptions.Timeout as e:
+            except RequestsTimeout as e:
                 self.log.exception(f"[FEATURE FLAGS] Request timed out: {e}")
                 feature_flag_error = "timeout"
-            except requests.exceptions.ConnectionError as e:
+            except RequestsConnectionError as e:
                 self.log.exception(f"[FEATURE FLAGS] Connection error: {e}")
                 feature_flag_error = "connection_error"
             except APIError as e:

posthog/request.py

@@ -312,6 +312,12 @@ class QuotaLimitError(APIError):
     pass
 
 
+# Re-export requests exceptions for use in client.py
+# This keeps all requests library imports centralized in this module
+RequestsTimeout = requests.exceptions.Timeout
+RequestsConnectionError = requests.exceptions.ConnectionError
+
+
 class DatetimeSerializer(json.JSONEncoder):
     def default(self, obj: Any):
         if isinstance(obj, (date, datetime)):

posthog/test/test_feature_flag_result.py

@@ -559,9 +559,9 @@ def test_get_feature_flag_result_unknown_error(self, patch_capture, patch_flags)
     @mock.patch.object(Client, "capture")
     def test_get_feature_flag_result_timeout_error(self, patch_capture, patch_flags):
         """Test that timeout errors are captured specifically."""
-        import requests.exceptions
+        from posthog.request import RequestsTimeout
 
-        patch_flags.side_effect = requests.exceptions.Timeout("Request timed out")
+        patch_flags.side_effect = RequestsTimeout("Request timed out")
 
         flag_result = self.client.get_feature_flag_result("my-flag", "some-distinct-id")
 
@@ -584,11 +584,9 @@ def test_get_feature_flag_result_timeout_error(self, patch_capture, patch_flags)
     @mock.patch.object(Client, "capture")
     def test_get_feature_flag_result_connection_error(self, patch_capture, patch_flags):
         """Test that connection errors are captured specifically."""
-        import requests.exceptions
+        from posthog.request import RequestsConnectionError
 
-        patch_flags.side_effect = requests.exceptions.ConnectionError(
-            "Connection refused"
-        )
+        patch_flags.side_effect = RequestsConnectionError("Connection refused")
 
         flag_result = self.client.get_feature_flag_result("my-flag", "some-distinct-id")