Reorder parameters to matches_dependency_value

Author: haacked

posthog/feature_flags.py

@@ -158,7 +158,7 @@ def evaluate_flag_dependency(
         # For flag dependencies, we need to compare the actual flag result with expected value
         # using the flag_evaluates_to operator logic
         if operator == "flag_evaluates_to":
-            return matches_dependency_value(actual_value, expected_value)
+            return matches_dependency_value(expected_value, actual_value)
         else:
             # For backwards compatibility, treat other operators as exact comparison
             # but flag dependencies should use flag_evaluates_to
@@ -168,7 +168,7 @@ def evaluate_flag_dependency(
     return True
 
 
-def matches_dependency_value(actual_value, expected_value):
+def matches_dependency_value(expected_value, actual_value):
     """
     Check if the actual flag value matches the expected dependency value.
 
@@ -177,8 +177,8 @@ def matches_dependency_value(actual_value, expected_value):
     - Boolean case: must match expected boolean value
 
     Args:
-        actual_value: The actual value returned by the flag evaluation
         expected_value: The expected value from the property
+        actual_value: The actual value returned by the flag evaluation
 
     Returns:
         bool: True if the values match according to flag dependency rules

posthog/test/test_feature_flags.py

@@ -2076,28 +2076,28 @@ def test_matches_dependency_value(self):
 
         # String variant matches string exactly (case-insensitive)
         self.assertTrue(matches_dependency_value("control", "control"))
-        self.assertTrue(matches_dependency_value("Control", "control"))
-        self.assertTrue(matches_dependency_value("CONTROL", "control"))
-        self.assertFalse(matches_dependency_value("test", "control"))
+        self.assertTrue(matches_dependency_value("control", "Control"))
+        self.assertTrue(matches_dependency_value("control", "CONTROL"))
+        self.assertFalse(matches_dependency_value("control", "test"))
 
         # String variant matches boolean true (any variant is truthy)
-        self.assertTrue(matches_dependency_value("control", True))
-        self.assertTrue(matches_dependency_value("test", True))
-        self.assertFalse(matches_dependency_value("control", False))
+        self.assertTrue(matches_dependency_value(True, "control"))
+        self.assertTrue(matches_dependency_value(True, "test"))
+        self.assertFalse(matches_dependency_value(False, "control"))
 
         # Boolean matches boolean exactly
         self.assertTrue(matches_dependency_value(True, True))
         self.assertTrue(matches_dependency_value(False, False))
-        self.assertFalse(matches_dependency_value(True, False))
         self.assertFalse(matches_dependency_value(False, True))
+        self.assertFalse(matches_dependency_value(True, False))
 
         # Empty string doesn't match
-        self.assertFalse(matches_dependency_value("", True))
-        self.assertFalse(matches_dependency_value("", "control"))
+        self.assertFalse(matches_dependency_value(True, ""))
+        self.assertFalse(matches_dependency_value("control", ""))
 
         # Type mismatches
-        self.assertFalse(matches_dependency_value("control", 123))
-        self.assertFalse(matches_dependency_value(True, "control"))
+        self.assertFalse(matches_dependency_value(123, "control"))
+        self.assertFalse(matches_dependency_value("control", True))
 
     @mock.patch("posthog.client.Poller")
     @mock.patch("posthog.client.get")