Skip to content

Commit da69b68

Browse files
authored
fix: feature flag request use geoip_disable (#235)
* make feature flag request use geoip_disable
1 parent 57c3cba commit da69b68

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

posthog/client.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,7 @@ def get_flags_decision(
423423
"groups": groups,
424424
"person_properties": person_properties,
425425
"group_properties": group_properties,
426-
"disable_geoip": disable_geoip,
426+
"geoip_disable": disable_geoip,
427427
}
428428

429429
use_flags = is_token_in_rollout(

posthog/test/test_client.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@ def test_basic_capture_with_feature_flags_returns_active_only(self, patch_flags)
521521
groups={},
522522
person_properties=None,
523523
group_properties=None,
524-
disable_geoip=True,
524+
geoip_disable=True,
525525
)
526526

527527
@mock.patch("posthog.client.flags")
@@ -563,7 +563,7 @@ def test_basic_capture_with_feature_flags_and_disable_geoip_returns_correctly(se
563563
groups={},
564564
person_properties=None,
565565
group_properties=None,
566-
disable_geoip=False,
566+
geoip_disable=False,
567567
)
568568

569569
@mock.patch("posthog.client.flags")
@@ -1027,7 +1027,7 @@ def test_disable_geoip_default_on_decide(self, patch_flags):
10271027
groups={},
10281028
person_properties={"distinct_id": "some_id"},
10291029
group_properties={},
1030-
disable_geoip=True,
1030+
geoip_disable=True,
10311031
)
10321032
patch_flags.reset_mock()
10331033
client.feature_enabled("random_key", "feature_enabled_distinct_id", disable_geoip=True)
@@ -1039,7 +1039,7 @@ def test_disable_geoip_default_on_decide(self, patch_flags):
10391039
groups={},
10401040
person_properties={"distinct_id": "feature_enabled_distinct_id"},
10411041
group_properties={},
1042-
disable_geoip=True,
1042+
geoip_disable=True,
10431043
)
10441044
patch_flags.reset_mock()
10451045
client.get_all_flags_and_payloads("all_flags_payloads_id")
@@ -1051,7 +1051,7 @@ def test_disable_geoip_default_on_decide(self, patch_flags):
10511051
groups={},
10521052
person_properties={"distinct_id": "all_flags_payloads_id"},
10531053
group_properties={},
1054-
disable_geoip=False,
1054+
geoip_disable=False,
10551055
)
10561056

10571057
@mock.patch("posthog.client.Poller")
@@ -1090,7 +1090,7 @@ def test_default_properties_get_added_properly(self, patch_flags):
10901090
"company": {"$group_key": "id:5", "x": "y"},
10911091
"instance": {"$group_key": "app.posthog.com"},
10921092
},
1093-
disable_geoip=False,
1093+
geoip_disable=False,
10941094
)
10951095

10961096
patch_flags.reset_mock()
@@ -1116,7 +1116,7 @@ def test_default_properties_get_added_properly(self, patch_flags):
11161116
"company": {"$group_key": "group_override"},
11171117
"instance": {"$group_key": "app.posthog.com"},
11181118
},
1119-
disable_geoip=False,
1119+
geoip_disable=False,
11201120
)
11211121

11221122
patch_flags.reset_mock()
@@ -1130,7 +1130,7 @@ def test_default_properties_get_added_properly(self, patch_flags):
11301130
groups={},
11311131
person_properties={"distinct_id": "some_id"},
11321132
group_properties={},
1133-
disable_geoip=False,
1133+
geoip_disable=False,
11341134
)
11351135

11361136
@parameterized.expand(

0 commit comments

Comments
 (0)