Skip to content

Commit dbc22d2

Browse files
committed
Add UUID to ID_TYPES
1 parent d66f944 commit dbc22d2

File tree

3 files changed

+14
-4
lines changed

3 files changed

+14
-4
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ dist/
55
MANIFEST
66
build/
77
.eggs/
8-
.coverage/
8+
.coverage
99
.vscode/
1010
env/
1111
venv/

posthog/client.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
import logging
44
import numbers
55
from datetime import datetime, timedelta
6-
from uuid import uuid4
6+
from uuid import UUID, uuid4
77

8-
import requests
98
from dateutil.tz import tzutc
109
from six import string_types
1110

@@ -21,7 +20,7 @@
2120
import Queue as queue
2221

2322

24-
ID_TYPES = (numbers.Number, string_types)
23+
ID_TYPES = (numbers.Number, string_types, UUID)
2524
__LONG_SCALE__ = float(0xFFFFFFFFFFFFFFF)
2625

2726

posthog/test/client.py

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import time
22
import unittest
33
from datetime import date, datetime
4+
from uuid import uuid4
45

56
import mock
67
import six
@@ -122,6 +123,16 @@ def test_basic_page(self):
122123
self.assertEqual(msg["distinct_id"], "distinct_id")
123124
self.assertEqual(msg["properties"]["$current_url"], "https://posthog.com/contact")
124125

126+
def test_basic_page_distinct_uuid(self):
127+
client = self.client
128+
distinct_id = uuid4()
129+
success, msg = client.page(distinct_id, url="https://posthog.com/contact")
130+
self.assertFalse(self.failed)
131+
client.flush()
132+
self.assertTrue(success)
133+
self.assertEqual(msg["distinct_id"], str(distinct_id))
134+
self.assertEqual(msg["properties"]["$current_url"], "https://posthog.com/contact")
135+
125136
def test_advanced_page(self):
126137
client = self.client
127138
success, msg = client.page(

0 commit comments

Comments
 (0)