Merge pull request #10 from PostHog/warn-instead-of-error

Warn instead of error

Author: timgl

posthog/client.py

@@ -228,7 +228,9 @@ def shutdown(self):
 
     def _load_feature_flags(self):
         if not self.personal_api_key:
-            raise ValueError('You have to specify a personal_api_key to use feature flags.')
+            self.log.warning('[FEATURE FLAGS] You have to specify a personal_api_key to use feature flags.')
+            self.feature_flags = []
+            return
 
         try:
             self.feature_flags = get(self.personal_api_key, '/api/feature_flag/', self.host)['results']
@@ -256,6 +258,8 @@ def feature_enabled(self, key, distinct_id, default=False):
         require('distinct_id', distinct_id, ID_TYPES)
         error = False
 
+        if not self.personal_api_key:
+            self.log.warning('[FEATURE FLAGS] You have to specify a personal_api_key to use feature flags.')
         if not self.feature_flags:
             self.load_feature_flags()
 

posthog/test/client.py

@@ -274,14 +274,24 @@ def test_feature_enabled_request(self, patch_get):
         }]
         self.assertTrue(client.feature_enabled('beta-feature', 'distinct_id'))
 
+    @mock.patch('posthog.client.Poller')
     @mock.patch('posthog.client.get')
-    def test_feature_enabled_doesnt_exist(self, patch_get):
+    def test_feature_enabled_doesnt_exist(self, patch_get, patch_poll):
         client = Client(TEST_API_KEY, personal_api_key='test')
         client.feature_flags = []
 
         self.assertFalse(client.feature_enabled('doesnt-exist', 'distinct_id'))
         self.assertTrue(client.feature_enabled('doesnt-exist', 'distinct_id', True))
 
+    @mock.patch('posthog.client.Poller')
+    @mock.patch('posthog.client.get')
+    def test_personal_api_key_doesnt_exist(self, patch_get, patch_poll):
+        client = Client(TEST_API_KEY)
+        client.feature_flags = []
+
+        self.assertFalse(client.feature_enabled('doesnt-exist', 'distinct_id'))
+        self.assertTrue(client.feature_enabled('doesnt-exist', 'distinct_id', True))
+
     @mock.patch('posthog.client.Poller')
     @mock.patch('posthog.client.get')
     def test_load_feature_flags_error(self, patch_get, patch_poll):