refactor: remove privacy_mode param, always use client setting

Author: andrewm4894

posthog/ai/pydantic_ai/instrument.py

@@ -12,7 +12,6 @@
 def instrument_pydantic_ai(
     client: PostHogClient,
     distinct_id: Optional[str] = None,
-    privacy_mode: Optional[bool] = None,
     properties: Optional[Dict[str, Any]] = None,
     groups: Optional[Dict[str, Any]] = None,
     debug: bool = False,
@@ -39,8 +38,6 @@ def instrument_pydantic_ai(
         client: PostHog client instance for sending events
         distinct_id: Default distinct ID for all events. If not provided,
             events will use the trace ID as distinct_id.
-        privacy_mode: If True, message content will be redacted from events.
-            If not specified, inherits from client.privacy_mode.
         properties: Additional properties to include in all events
         groups: PostHog groups to associate with all events
         debug: Enable debug logging for troubleshooting
@@ -68,9 +65,7 @@ def instrument_pydantic_ai(
 
     from posthog.ai.pydantic_ai.exporter import PydanticAISpanExporter
 
-    # Resolve privacy_mode from client if not explicitly set
-    if privacy_mode is None:
-        privacy_mode = getattr(client, "privacy_mode", False)
+    privacy_mode = getattr(client, "privacy_mode", False)
 
     # Create the Pydantic AI-specific exporter (handles message format normalization)
     exporter = PydanticAISpanExporter(

posthog/test/ai/pydantic_ai/test_instrument.py

@@ -41,11 +41,14 @@ def test_basic_instrumentation(self, mock_client):
             settings = mock_instrument_all.call_args[0][0]
             assert isinstance(settings, InstrumentationSettings)
 
-    def test_privacy_mode_disables_content(self, mock_client):
+    def test_privacy_mode_disables_content(self):
         from posthog.ai.pydantic_ai import instrument_pydantic_ai
 
+        client = MagicMock()
+        client.privacy_mode = True
+
         with patch.object(Agent, "instrument_all") as mock_instrument_all:
-            instrument_pydantic_ai(mock_client, privacy_mode=True)
+            instrument_pydantic_ai(client)
 
             settings = mock_instrument_all.call_args[0][0]
             assert settings.include_content is False
@@ -54,7 +57,7 @@ def test_privacy_mode_false_includes_content(self, mock_client):
         from posthog.ai.pydantic_ai import instrument_pydantic_ai
 
         with patch.object(Agent, "instrument_all") as mock_instrument_all:
-            instrument_pydantic_ai(mock_client, privacy_mode=False)
+            instrument_pydantic_ai(mock_client)
 
             settings = mock_instrument_all.call_args[0][0]
             assert settings.include_content is True