code review

Author: dmarticus

posthog/client.py

@@ -607,6 +607,12 @@ def _load_feature_flags(self):
                 self.feature_flags_by_key = {}
                 self.group_type_mapping = {}
                 self.cohorts = {}
+                
+                if self.debug:
+                    raise APIError(
+                        status=402,
+                        message="PostHog feature flags quota limited",
+                    )
             else:
                 self.log.error(f"[FEATURE FLAGS] Error loading feature flags: {e}")
         except Exception as e:

posthog/request.py

@@ -70,6 +70,8 @@ def _process_response(
         log.debug(success_message)
         response = res.json() if return_json else res
         # Handle quota limited decide responses by raising a specific error
+        # NB: other services also put entries into the quotaLimited key, but right now we only care about feature flags
+        # since most of the other services handle quota limiting in other places in the application.
         if (
             isinstance(response, dict)
             and "quotaLimited" in response