chore: renable bundled size checking now main and PR will be on pnpm (#120)

for https://app.graphite.com/github/pr/PostHog/posthog-rrweb/107/chore-switch-from-yarn-to-pnpm i had to disable bundled size checking

because main was on yarn and PR was on PNPM

now that that is merged, we can re-enable bundled size checking

Author: pauldambra

.github/workflows/ci-cd.yml

@@ -40,14 +40,13 @@ jobs:
       - name: Run tests
         run: PUPPETEER_HEADLESS=true xvfb-run --server-args="-screen 0 1920x1080x24" pnpm test
 
-      # TODO: Re-enable after pnpm migration is merged to main
-      # - name: Check bundle sizes
-      #   uses: preactjs/compressed-size-action@v2
-      #   with:
-      #     install-script: "pnpm install --frozen-lockfile"
-      #     build-script: "build:all"
-      #     compression: "none"
-      #     pattern: "**/dist/*.{js,cjs,mjs,css}"
+      - name: Check bundle sizes
+        uses: preactjs/compressed-size-action@v2
+        with:
+         install-script: "pnpm install --frozen-lockfile"
+         build-script: "build:all"
+         compression: "none"
+         pattern: "**/dist/*.{js,cjs,mjs,css}"
 
       - name: Upload diff images to GitHub
         uses: actions/upload-artifact@v4

packages/rrweb/test/record/cross-origin-iframes.test.ts

@@ -46,21 +46,28 @@ type ExtraOptions = {
 async function injectRecordScript(
   frame: puppeteer.Frame,
   options?: ExtraOptions,
+  retryCount = 0,
 ) {
+  const MAX_RETRIES = 5;
   try {
     await frame.addScriptTag({
       path: path.resolve(__dirname, '../../dist/rrweb.umd.cjs'),
     });
   } catch (e) {
-    // we get this error: `Protocol error (DOM.resolveNode): Node with given id does not belong to the document`
-    // then the page wasn't loaded yet and we try again
-    if (
-      !e.message.includes('DOM.resolveNode') ||
-      !e.message.includes('DOM.describeNode')
-    )
-      throw e;
-    await injectRecordScript(frame, options);
-    return;
+    const retryableErrors = [
+      'DOM.resolveNode',
+      'DOM.describeNode',
+      'Execution context was destroyed',
+    ];
+    const isRetryable = retryableErrors.some((error) =>
+      e.message.includes(error),
+    );
+    if (isRetryable && retryCount < MAX_RETRIES) {
+      await new Promise((resolve) => setTimeout(resolve, 50));
+      await injectRecordScript(frame, options, retryCount + 1);
+      return;
+    }
+    throw e;
   }
   options = options || {};
   await frame.evaluate((options) => {