feat(ma): add reported conversion value to marketing analytics (#41939)

Co-authored-by: Javier Bahamondes <[email protected]>

Author: jabahamondes

frontend/src/queries/schema.json

@@ -17986,7 +17986,18 @@
             "type": "object"
         },
         "MarketingAnalyticsBaseColumns": {
-            "enum": ["ID", "Campaign", "Source", "Cost", "Clicks", "Impressions", "CPC", "CTR", "Reported Conversion"],
+            "enum": [
+                "ID",
+                "Campaign",
+                "Source",
+                "Cost",
+                "Clicks",
+                "Impressions",
+                "CPC",
+                "CTR",
+                "Reported Conversion",
+                "Reported Conversion Value"
+            ],
             "type": "string"
         },
         "MarketingAnalyticsColumnsSchemaNames": {
@@ -17999,7 +18010,8 @@
                 "date",
                 "impressions",
                 "source",
-                "reported_conversion"
+                "reported_conversion",
+                "reported_conversion_value"
             ],
             "type": "string"
         },
@@ -28050,6 +28062,9 @@
                 "reported_conversion": {
                     "type": "string"
                 },
+                "reported_conversion_value": {
+                    "type": "string"
+                },
                 "source": {
                     "type": "string"
                 }

frontend/src/queries/schema/schema-general.ts

@@ -4321,6 +4321,7 @@ export enum MarketingAnalyticsColumnsSchemaNames {
     Impressions = 'impressions',
     Source = 'source',
     ReportedConversion = 'reported_conversion',
+    ReportedConversionValue = 'reported_conversion_value',
 }
 
 export const MARKETING_ANALYTICS_SCHEMA: Record<MarketingAnalyticsColumnsSchemaNames, MarketingAnalyticsSchemaField> = {
@@ -4349,6 +4350,11 @@ export const MARKETING_ANALYTICS_SCHEMA: Record<MarketingAnalyticsColumnsSchemaN
         required: false,
         isCurrency: false,
     },
+    [MarketingAnalyticsColumnsSchemaNames.ReportedConversionValue]: {
+        type: ['integer', 'number', 'float'],
+        required: false,
+        isCurrency: true,
+    },
 }
 
 export type SourceMap = Record<MarketingAnalyticsColumnsSchemaNames, string | undefined>
@@ -4395,6 +4401,7 @@ export enum MarketingAnalyticsBaseColumns {
     CPC = 'CPC',
     CTR = 'CTR',
     ReportedConversion = 'Reported Conversion',
+    ReportedConversionValue = 'Reported Conversion Value',
 }
 
 export enum MarketingAnalyticsHelperForColumnNames {

posthog/schema.py

@@ -2009,6 +2009,7 @@ class MarketingAnalyticsBaseColumns(StrEnum):
     CPC = "CPC"
     CTR = "CTR"
     REPORTED_CONVERSION = "Reported Conversion"
+    REPORTED_CONVERSION_VALUE = "Reported Conversion Value"
 
 
 class MarketingAnalyticsColumnsSchemaNames(StrEnum):
@@ -2021,6 +2022,7 @@ class MarketingAnalyticsColumnsSchemaNames(StrEnum):
     IMPRESSIONS = "impressions"
     SOURCE = "source"
     REPORTED_CONVERSION = "reported_conversion"
+    REPORTED_CONVERSION_VALUE = "reported_conversion_value"
 
 
 class MarketingAnalyticsHelperForColumnNames(StrEnum):
@@ -3147,6 +3149,7 @@ class SourceMap(BaseModel):
     id: str | None = None
     impressions: str | None = None
     reported_conversion: str | None = None
+    reported_conversion_value: str | None = None
     source: str | None = None
 
 

posthog/temporal/data_imports/sources/linkedin_ads/schemas.py

@@ -3,7 +3,7 @@
 
 from products.data_warehouse.backend.types import IncrementalFieldType
 
-FLOAT_FIELDS = {"costInUsd"}
+FLOAT_FIELDS = {"costInUsd", "conversionValueInLocalCurrency"}
 
 # There are in the results from the API. The value is in the URN format.
 URN_COLUMNS = ["campaignGroup", "account", "campaign", "creative"]
@@ -125,6 +125,7 @@ class ResourceSchema(TypedDict):
             "pivotValues",
             "costInUsd",
             "externalWebsiteConversions",
+            "conversionValueInLocalCurrency",
             "landingPageClicks",
             "totalEngagements",
             "videoViews",
@@ -151,6 +152,7 @@ class ResourceSchema(TypedDict):
             "pivotValues",
             "costInUsd",
             "externalWebsiteConversions",
+            "conversionValueInLocalCurrency",
             "landingPageClicks",
             "totalEngagements",
             "videoViews",

posthog/temporal/data_imports/sources/tiktok_ads/settings.py

@@ -26,6 +26,8 @@
     "conversion_rate_v2",
     "conversion_rate",
     "conversion",
+    "complete_payment",
+    "total_complete_payment_value",
     "cost_per_1000_reached",
     "cost_per_conversion",
     "cost_per_result",

products/marketing_analytics/backend/hogql_queries/__snapshots__/test_adapters.ambr

@@ -3,10 +3,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM
@@ -67,10 +67,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM
@@ -131,10 +131,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM
@@ -195,10 +195,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM
@@ -259,10 +259,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM
@@ -323,10 +323,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_1
 
   FROM
@@ -387,10 +387,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       coalesce(sum(conversion_value), 0) AS conversion_0
 
   FROM
@@ -451,10 +451,10 @@
   '''
 
   SELECT
+      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       if(notEmpty(campaign_name), campaign_name, 'organic') AS campaign,
       if(notEmpty(campaign_id), campaign_id, '-') AS id,
       if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['microsoft']), 'bing', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['facebook', 'instagram', 'messenger', 'fb', 'whatsapp', 'audience_network', 'facebook_marketplace', 'threads']), 'meta', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['li']), 'linkedin', if(in(lower(if(notEmpty(source_name), source_name, 'organic')), ['adwords', 'youtube', 'display', 'gmail', 'google_maps', 'google_play', 'google_discover', 'admob', 'waze']), 'google', if(notEmpty(source_name), source_name, 'organic'))))) AS source,
-      if(notEmpty(campaign_name), campaign_name, 'organic') AS match_key,
       count() AS conversion_0
 
   FROM

products/marketing_analytics/backend/hogql_queries/__snapshots__/test_conversion_goal_processor.ambr

@@ -2,7 +2,7 @@
 # name: TestMarketingAnalyticsAggregatedQueryRunner.test_join_uses_match_key_not_or_condition
   '''
 
-  SELECT sum(round(campaign_costs.total_cost, 2)) AS Cost, sum(round(campaign_costs.total_clicks, 0)) AS Clicks, sum(round(campaign_costs.total_impressions, 0)) AS Impressions, sum(round(campaign_costs.total_reported_conversions, 2)) AS `Reported Conversion`, sum(ucg.conversion_0) AS `Test Purchase` 
+  SELECT sum(round(campaign_costs.total_cost, 2)) AS Cost, sum(round(campaign_costs.total_clicks, 0)) AS Clicks, sum(round(campaign_costs.total_impressions, 0)) AS Impressions, sum(round(campaign_costs.total_reported_conversions, 2)) AS `Reported Conversion`, sum(round(campaign_costs.total_reported_conversion_value, 2)) AS `Reported Conversion Value`, sum(ucg.conversion_0) AS `Test Purchase` 
   FROM campaign_costs LEFT JOIN ucg AS ucg ON and(equals(campaign_costs.match_key, ucg.match_key), equals(campaign_costs.source, ucg.source))
   '''
 # ---