chore: Move logic to logic file

Author: arthurdedeus

frontend/src/scenes/notebooks/Nodes/NotebookNodePlaylist.tsx

@@ -17,7 +17,7 @@ import {
 } from 'scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic'
 import { urls } from 'scenes/urls'
 
-import { AnyPropertyFilter, FilterType, RecordingUniversalFilters, ReplayTabs } from '~/types'
+import { FilterType, RecordingUniversalFilters, ReplayTabs } from '~/types'
 
 import { notebookLogic } from '../Notebook/notebookLogic'
 import { NotebookNodeAttributeProperties, NotebookNodeProps, NotebookNodeType } from '../types'
@@ -29,14 +29,13 @@ const Component = ({
 }: NotebookNodeProps<NotebookNodePlaylistAttributes>): JSX.Element => {
     const { pinned, nodeId, universalFilters } = attributes
     const playerKey = `notebook-${nodeId}`
-    const { canvasFiltersOverride } = useValues(notebookLogic)
-    const personUUID = getPersonUUIDFromOverride(canvasFiltersOverride)
+    const { personUUIDFromCanvasOverride } = useValues(notebookLogic)
 
     const recordingPlaylistLogicProps: SessionRecordingPlaylistLogicProps = useMemo(
         () => ({
             logicKey: playerKey,
             filters: universalFilters,
-            ...(personUUID ? { personUUID } : {}),
+            ...(personUUIDFromCanvasOverride ? { personUUID: personUUIDFromCanvasOverride } : {}),
             updateSearchParams: false,
             autoPlay: false,
             onFiltersChange: (newFilters) => updateAttributes({ universalFilters: newFilters }),
@@ -168,10 +167,3 @@ export function buildPlaylistContent(filters: Partial<FilterType>): JSONContent
         attrs: { filters },
     }
 }
-
-function getPersonUUIDFromOverride(override: AnyPropertyFilter[] | null): string | null {
-    if (!override || override.length === 0) {
-        return null
-    }
-    return override.find((filter) => filter.key === 'person_id')?.value as string
-}

frontend/src/scenes/notebooks/Notebook/notebookLogic.ts

@@ -503,6 +503,17 @@ export const notebookLogic = kea<notebookLogicType>([
                 return insightNodes?.map((node) => node?.attrs?.query?.shortId)
             },
         ],
+
+        personUUIDFromCanvasOverride: [
+            () => [(_, props) => props],
+            (props: NotebookLogicProps): string | null => {
+                if (!props.canvasFiltersOverride || props.canvasFiltersOverride.length === 0) {
+                    return null
+                }
+                return props.canvasFiltersOverride.find((filter: AnyPropertyFilter) => filter.key === 'person_id')
+                    ?.value as string
+            },
+        ],
     }),
     listeners(({ values, actions, cache }) => ({
         insertAfterLastNode: async ({ content }) => {