fix: Stop producing intent for surveys on settings page (#42540)

Everytime someone loads the Settings page we're triggering intent for surveys which isn't right. This happens because we load all surveys there,
and simply loading surveys is enough to trigger intent.

Intent should only be triggered when someone is *actively* using the product, so let's remove this completely.

Author: rafaeelaudibert

frontend/src/queries/schema/schema-general.ts

@@ -4914,7 +4914,7 @@ export enum ProductIntentContext {
     DATA_WAREHOUSE_STRIPE_SOURCE_CREATED = 'data_warehouse_stripe_source_created',
 
     // Surveys
-    SURVEYS_VIEWED = 'surveys_viewed', // accessed surveys page
+    SURVEYS_VIEWED = 'surveys_viewed', // deprecated, not used anymore
     SURVEY_CREATED = 'survey_created',
     SURVEY_LAUNCHED = 'survey_launched',
     SURVEY_VIEWED = 'survey_viewed',

frontend/src/scenes/surveys/surveysLogic.tsx

@@ -312,14 +312,6 @@ export const surveysLogic = kea<surveysLogicType>([
         loadSurveysSuccess: () => {
             actions.loadCurrentTeam()
 
-            actions.addProductIntent({
-                product_type: ProductKey.SURVEYS,
-                intent_context: ProductIntentContext.SURVEYS_VIEWED,
-                metadata: {
-                    surveys_count: values.data.surveysCount,
-                },
-            })
-
             if (values.data.surveys.some((survey) => survey.start_date)) {
                 activationLogic.findMounted()?.actions.markTaskAsCompleted(ActivationTask.LaunchSurvey)
             }