chore(plugin-server): Remove unused objectStorage (#42187)

Author: jose-sequeira

plugin-server/src/config/config.ts

@@ -131,12 +131,6 @@ export function getDefaultConfig(): PluginsServerConfig {
         CLICKHOUSE_HEATMAPS_KAFKA_TOPIC: KAFKA_CLICKHOUSE_HEATMAP_EVENTS,
         PERSON_INFO_CACHE_TTL: 5 * 60, // 5 min
         KAFKA_HEALTHCHECK_SECONDS: 20,
-        OBJECT_STORAGE_ENABLED: true,
-        OBJECT_STORAGE_ENDPOINT: 'http://localhost:19000',
-        OBJECT_STORAGE_REGION: 'us-east-1',
-        OBJECT_STORAGE_ACCESS_KEY_ID: 'object_storage_root_user',
-        OBJECT_STORAGE_SECRET_ACCESS_KEY: 'object_storage_root_password',
-        OBJECT_STORAGE_BUCKET: 'posthog',
         PLUGIN_SERVER_MODE: null,
         PLUGIN_SERVER_EVENTS_INGESTION_PIPELINE: null,
         PLUGIN_LOAD_SEQUENTIALLY: false,

plugin-server/src/types.ts

@@ -30,7 +30,6 @@ import { Celery } from './utils/db/celery'
 import { DB } from './utils/db/db'
 import { PostgresRouter } from './utils/db/postgres'
 import { GeoIPService } from './utils/geoip'
-import { ObjectStorage } from './utils/object_storage'
 import { PubSub } from './utils/pubsub'
 import { TeamManager } from './utils/team-manager'
 import { UUID } from './utils/utils'
@@ -371,12 +370,6 @@ export interface PluginsServerConfig extends CdpConfig, IngestionConsumerConfig,
     KAFKA_PARTITIONS_CONSUMED_CONCURRENTLY: number // (advanced) how many kafka partitions the plugin server should consume from concurrently
     PERSON_INFO_CACHE_TTL: number
     KAFKA_HEALTHCHECK_SECONDS: number
-    OBJECT_STORAGE_ENABLED: boolean // Disables or enables the use of object storage. It will become mandatory to use object storage
-    OBJECT_STORAGE_REGION: string // s3 region
-    OBJECT_STORAGE_ENDPOINT: string // s3 endpoint
-    OBJECT_STORAGE_ACCESS_KEY_ID: string
-    OBJECT_STORAGE_SECRET_ACCESS_KEY: string
-    OBJECT_STORAGE_BUCKET: string // the object storage bucket name
     PLUGIN_SERVER_MODE: PluginServerMode | null
     PLUGIN_SERVER_EVENTS_INGESTION_PIPELINE: string | null // TODO: shouldn't be a string probably
     PLUGIN_LOAD_SEQUENTIALLY: boolean // could help with reducing memory usage spikes on startup
@@ -515,7 +508,6 @@ export interface Hub extends PluginsServerConfig {
     cookielessRedisPool: GenericPool<Redis>
     kafka: Kafka
     kafkaProducer: KafkaProducerWrapper
-    objectStorage?: ObjectStorage
     // currently enabled plugin status
     plugins: Map<PluginId, Plugin>
     pluginConfigs: Map<PluginConfigId, PluginConfig>

plugin-server/src/utils/db/hub.ts

@@ -29,7 +29,6 @@ import { ActionManagerCDP } from '../action-manager-cdp'
 import { isTestEnv } from '../env-utils'
 import { GeoIPService } from '../geoip'
 import { logger } from '../logger'
-import { getObjectStorage } from '../object_storage'
 import { PubSub } from '../pubsub'
 import { TeamManager } from '../team-manager'
 import { UUIDT } from '../utils'
@@ -107,15 +106,6 @@ export async function createHub(
     const cookielessRedisPool = createRedisPool(serverConfig, 'cookieless')
     logger.info('👍', `Cookieless Redis ready`)
 
-    logger.info('🤔', `Connecting to object storage...`)
-
-    const objectStorage = getObjectStorage(serverConfig)
-    if (objectStorage) {
-        logger.info('👍', 'Object storage ready')
-    } else {
-        logger.warn('🪣', `Object storage could not be created`)
-    }
-
     const db = new DB(
         postgres,
         postgresPersonMigration,
@@ -170,7 +160,6 @@ export async function createHub(
         cookielessRedisPool,
         kafka,
         kafkaProducer,
-        objectStorage: objectStorage,
         groupTypeManager,
 
         plugins: new Map(),