chore: remove deprecated FeatureFlagEvaluationTag and TeamDefaultEvaluationTag models (#52186)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: dmarticus

.github/scripts/check-idor-model-coverage.py

@@ -144,7 +144,6 @@ def get_scoped_models() -> tuple[dict[str, set[str]], set[str]]:
         "TeamConversationsSlackConfig",
         "TeamCustomerAnalyticsConfig",
         "TeamDefaultEvaluationContext",
-        "TeamDefaultEvaluationTag",
         "TeamDataWarehouseConfig",
         "TeamMarketingAnalyticsConfig",
         "TeamRevenueAnalyticsConfig",

ee/clickhouse/views/experiments.py

@@ -444,7 +444,7 @@ def eligible_feature_flags(self, request: Request, **kwargs: Any) -> Response:
         - created_by_id: Filter by creator user ID
         - order: Sort order field
         - evaluation_runtime: Filter by evaluation runtime
-        - has_evaluation_tags: Filter by presence of evaluation tags ("true" or "false")
+        - has_evaluation_contexts: Filter by presence of evaluation contexts ("true" or "false")
         """
         # validate limit and offset
         try:
@@ -469,7 +469,7 @@ def eligible_feature_flags(self, request: Request, **kwargs: Any) -> Response:
             created_by_id=request.query_params.get("created_by_id"),
             order=request.query_params.get("order"),
             evaluation_runtime=request.query_params.get("evaluation_runtime"),
-            has_evaluation_tags=request.query_params.get("has_evaluation_tags"),
+            has_evaluation_contexts=request.query_params.get("has_evaluation_contexts"),
         )
 
         # Serialize using the standard FeatureFlagSerializer

frontend/src/mocks/handlers.ts

@@ -216,7 +216,6 @@ export const defaultMocks: Mocks = {
         '/api/organizations/:organization_id/proxy_records/': [],
         '/api/projects/:team_id/dashboard_templates/json_schema/': EMPTY_PAGINATED_RESPONSE,
         '/api/organizations/:organization_id/domains/': EMPTY_PAGINATED_RESPONSE,
-        '/api/environments/:team_id/default_evaluation_tags/': EMPTY_PAGINATED_RESPONSE,
         '/api/environments/:team_id/default_evaluation_contexts/': {
             default_evaluation_contexts: [],
             available_contexts: [],

frontend/src/scenes/experiments/ExperimentForm/SelectExistingFeatureFlagModal.test.tsx

@@ -55,7 +55,6 @@ describe('SelectExistingFeatureFlagModal', () => {
         version: 0,
         last_modified_by: null,
         evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-        evaluation_tags: [],
         evaluation_contexts: [],
         bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
     }

frontend/src/scenes/experiments/ExperimentForm/VariantsPanelLinkFeatureFlag.test.tsx

@@ -56,7 +56,6 @@ describe('VariantsPanelLinkFeatureFlag', () => {
         version: 0,
         last_modified_by: null,
         evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-        evaluation_tags: [],
         evaluation_contexts: [],
         bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
     }

frontend/src/scenes/experiments/ExperimentForm/selectExistingFeatureFlagModalLogic.test.ts

@@ -50,7 +50,6 @@ describe('selectExistingFeatureFlagModalLogic', () => {
             version: 0,
             last_modified_by: null,
             evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-            evaluation_tags: [],
             evaluation_contexts: [],
             bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
         },
@@ -88,7 +87,6 @@ describe('selectExistingFeatureFlagModalLogic', () => {
             version: 0,
             last_modified_by: null,
             evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-            evaluation_tags: [],
             evaluation_contexts: [],
             bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
         },

frontend/src/scenes/experiments/ExperimentForm/selectExistingFeatureFlagModalLogic.ts

@@ -128,9 +128,9 @@ export const selectExistingFeatureFlagModalLogic = kea<selectExistingFeatureFlag
                     offset: filters.page ? (filters.page - 1) * FLAGS_PER_PAGE : 0,
                 }
 
-                // Add evaluation tags filter if required by team
+                // Add evaluation contexts filter if required by team
                 if (currentTeam?.require_evaluation_contexts) {
-                    params.has_evaluation_tags = true
+                    params.has_evaluation_contexts = true
                 }
 
                 return params

frontend/src/scenes/experiments/experimentsLogic.ts

@@ -387,9 +387,9 @@ export const experimentsLogic = kea<experimentsLogicType>([
                     offset: filters.page ? (filters.page - 1) * FLAGS_PER_PAGE : 0,
                 }
 
-                // Add evaluation tags filter if required by team
+                // Add evaluation contexts filter if required by team
                 if (currentTeam?.require_evaluation_contexts) {
-                    params.has_evaluation_tags = true
+                    params.has_evaluation_contexts = true
                 }
 
                 return params

frontend/src/scenes/experiments/utils.test.ts

@@ -695,7 +695,6 @@ describe('checkFeatureFlagEligibility', () => {
         version: 0,
         last_modified_by: null,
         evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-        evaluation_tags: [],
         evaluation_contexts: [],
         bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
     }

frontend/src/scenes/feature-flags/FeatureFlagCodeInstructions.stories.tsx

@@ -42,7 +42,6 @@ const REGULAR_FEATURE_FLAG: FeatureFlagType = {
     version: 0,
     last_modified_by: null,
     evaluation_runtime: FeatureFlagEvaluationRuntime.ALL,
-    evaluation_tags: [],
     evaluation_contexts: [],
     bucketing_identifier: FeatureFlagBucketingIdentifier.DISTINCT_ID,
 }