chore: make error tracking UI full with and remove card style #42240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
requested review from
a team,
ablaszkiewicz,
Copilot,
hpouillot and
oliverb123
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Outdated
Show resolved
Hide resolved
| // Click event is caught at the row level | ||
| return ( | ||
| <div className="flex items-center"> | ||
| <input type="radio" className="cursor-pointer" checked={isEventSelected(record)} onChange={() => {}} /> |
Contributor
There was a problem hiding this comment.
logic: missing name attribute on radio button prevents it from being part of a radio group
Prompt To Fix With AI
This is a comment left during a code review.
Path: products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Line: 85:85
Comment:
**logic:** missing `name` attribute on radio button prevents it from being part of a radio group
How can I resolve this? If you propose a fix, please make it concise.
products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Outdated
Show resolved
Hide resolved
Copilot finished reviewing on behalf of
daibhin
November 27, 2025 17:52
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Error Tracking Issue Scene UI to achieve a cleaner, full-width panel layout by removing nested cards and collapsible sections for filters.
Key Changes:
- Removed the LemonCollapse component wrapping the filters, making them always visible
- Removed card nesting in ExceptionCard by setting border and border-radius to none
- Restored the selected state functionality in the EventsTable with a radio button column
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ErrorTrackingIssueScene.tsx | Restructured layout to use fragment wrapper, removed LemonCollapse import, moved filters out of collapsible panel, added selectedEvent state to EventsTable, adjusted spacing/padding |
| ExceptionCard.tsx | Removed unused cn import, updated className to remove border and rounded corners for seamless integration |
| EventsTable.tsx | Added selectedEvent prop, implemented radio button selection column with isEventSelected helper, enabled row click handling with stealth mode |
| DataSourceTable.tsx | Added stealth prop type definition and forwarding to LemonTable for cleaner table styling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| // Click event is caught at the row level | ||
| return ( | ||
| <div className="flex items-center"> | ||
| <input type="radio" className="cursor-pointer" checked={isEventSelected(record)} onChange={() => {}} /> |
There was a problem hiding this comment.
The radio button should have a name attribute to group related radio buttons together. All radio buttons in this table should share the same name to ensure proper radio button behavior where only one can be selected at a time.
Additionally, the radio button lacks an accessible label. Consider adding an aria-label attribute for screen readers.
Suggested change
| <input type="radio" className="cursor-pointer" checked={isEventSelected(record)} onChange={() => {}} /> | |
| <input | |
| type="radio" | |
| className="cursor-pointer" | |
| checked={isEventSelected(record)} | |
| onChange={() => {}} | |
| name={`event-select-${queryKey}`} | |
| aria-label={`Select event ${record.uuid}`} | |
| /> |
products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Outdated
Show resolved
Hide resolved
products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Size Change: 0 B Total Size: 3.41 MB ℹ️ View Unchanged
|
ablaszkiewicz
approved these changes
Nov 27, 2025
products/error_tracking/frontend/components/EventsTable/EventsTable.tsx
Outdated
Show resolved
Hide resolved
daibhin
changed the title
daibhin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes