Skip to content

Conversation

@sortafreel
Copy link
Contributor

@sortafreel sortafreel commented Nov 27, 2025

Problem

  • Some events are recorded before we have a Replay session, so they aren't visible in the player/recording
  • Events at the very start of the session are usually render-related and spammy, so don't mean much
  • Events at the very end aren't verifiable, as we can't render a video either

Changes

  • If the event tracked before Replay session started recording, after the session end, or 5s threshold - filter it out before sending to LLM

How did you test this code?

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Changelog: (features only) Is this feature complete?

@sortafreel sortafreel requested a review from Twixes November 27, 2025 20:34
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@sortafreel sortafreel changed the title feat(signals): Ignore events before replay session starts feat(signals): Ignore events before replay session starts + 5s Nov 28, 2025
Copy link
Member

@Twixes Twixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lookin good, no notes

@sortafreel sortafreel changed the title feat(signals): Ignore events before replay session starts + 5s feat(signals): Ignore events before replay session starts / after ends + 5s Dec 2, 2025
@sortafreel sortafreel enabled auto-merge (squash) December 2, 2025 12:39
@sortafreel sortafreel merged commit 1af5ccc into master Dec 2, 2025
175 checks passed
@sortafreel sortafreel deleted the signals/ignore-events-before-replay branch December 2, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants