feat(cymbal): add ios raw frame #42270
Conversation
| pub mod dart; | ||
| pub mod go; | ||
| pub mod hermes; | ||
| pub mod ios; |
There was a problem hiding this comment.
Should we be using the language here not the platform? Are these Swift or Objective C frames or something else? I can see a world where it's confusing for "iOS frames" to process MacOS exceptions
There was a problem hiding this comment.
Yeah expressed the same concern in PR body. To my best understanding frames will be identical (and handled similarly) regardless of swift/objc and platform. Not sure I can distinguish runtime in a deterministic way if a specific frame is objc/swift
Some other alternatives can be apple, apple-native?
There was a problem hiding this comment.
We also have java which also handles Kotlin and other jvm languages if I'm not mistaken? @marandaneto thoughts on this?
There was a problem hiding this comment.
kotlin compiles to java bytecode so its the same thing.
There was a problem hiding this comment.
i'd rather call it apple.
i think lang here is a confusing name since you only think about the language and its properties.
it should have been something more connected to the symbolication type.
eg
for code highlighting:
lang=kotlin | java | etc
for symbolication:
symbol_type (or platform)=elf (linux) | proguard | r8 (android/java/kotlin) | sourcemaps (web) | Mach-O (apple) | etc
right now we are using lang as a way to trigger a certain symbolication process, in my example, symbol_type.
on the SDK side we use platform which can be hermes and then it symbolicates to javascript, see the confusion.
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
marandaneto
requested review from
a team,
ablaszkiewicz,
daibhin,
hpouillot and
oliverb123
|
@ioannisj lets get this out of the door? |
Problem
Add raw iOS frames to cymbal.
"ios" does not really fit with langs, but I could not come up with anything clearer here
Changes
How did you test this code?
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Changelog: (features only) Is this feature complete?