Skip to content

Commit 9f810fc

Browse files
authored
Merge pull request #14 from PostHog/tom/fixbug
Fix permission set arn fetch bug
2 parents 5896ef1 + 9bfb61f commit 9f810fc

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

src/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ def handle_account_selection(ack: Ack, body: dict, client: WebClient) -> SlackRe
685685
permission_sets = sso.get_permission_sets_from_config_with_cache(sso_client=sso_client, s3_client=s3_client, cfg=cfg)
686686
else:
687687
all_ps = sso.get_permission_sets_from_config_with_cache(sso_client=sso_client, s3_client=s3_client, cfg=cfg)
688-
permission_sets = [ps for ps in all_ps if ps.name in valid_ps_names]
688+
permission_sets = [ps for ps in all_ps if ps.name in valid_ps_names or ps.arn in valid_ps_names]
689689

690690
# Handle case where filtered list is empty (configured names don't exist in SSO)
691691
if not permission_sets:

src/sso.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -469,7 +469,10 @@ def get_permission_sets_from_config(client: SSOAdminClient, cfg: config.Config)
469469
if "*" in cfg.permission_sets:
470470
permission_sets = list(list_permission_sets(client, cfg.sso_instance_arn))
471471
else:
472-
permission_sets = [ps for ps in list_permission_sets(client, cfg.sso_instance_arn) if ps.name in cfg.permission_sets]
472+
permission_sets = [
473+
ps for ps in list_permission_sets(client, cfg.sso_instance_arn)
474+
if ps.name in cfg.permission_sets or ps.arn in cfg.permission_sets
475+
]
473476
return permission_sets
474477

475478

0 commit comments

Comments
 (0)