Merge pull request #18 from PostHog/vdekrijger-typo-corrections-post-export

chore: Small corrections after exporting the alerts / hog functions locally

Author: vdekrijger

docs/resources/insight.md

@@ -24,7 +24,7 @@ Manage PostHog insights via the insights endpoints.
 - `create_in_folder` (String) The folder where the insight is created.
 - `dashboard_ids` (Set of Number) List of dashboard ids which should contain the insight.
 - `deleted` (Boolean) Whether the insight is deleted (soft delete)
-- `derived_name` (String) Insight derived name.
+- `derived_name` (String) Insight derived name. This is auto-generated by PostHog when the name is not set.
 - `description` (String) Insight description.
 - `name` (String) Insight name.
 - `tags` (Set of String) List of tags to apply to the insight.

internal/resource/hog_function.go

@@ -308,17 +308,19 @@ func (o HogFunctionOps) MapResponseToModel(ctx context.Context, resp httpclient.
 		}
 	}
 
-	if len(resp.Inputs) > 0 {
-		normalized, err := normalizeJSONForState(resp.Inputs, model.InputsJSON.ValueString())
-		if err != nil {
-			diags.AddError("Failed to normalize inputs", err.Error())
-			return diags
+	// Only update inputs_json if user configured it (not template-provided)
+	// This prevents inconsistent state when template provides default inputs
+	if !model.InputsJSON.IsNull() {
+		if len(resp.Inputs) > 0 {
+			normalized, err := normalizeJSONForState(resp.Inputs, model.InputsJSON.ValueString())
+			if err != nil {
+				diags.AddError("Failed to normalize inputs", err.Error())
+				return diags
+			}
+			model.InputsJSON = types.StringValue(normalized)
+		} else {
+			model.InputsJSON = types.StringValue("{}")
 		}
-		model.InputsJSON = types.StringValue(normalized)
-	} else if !model.InputsJSON.IsNull() {
-		model.InputsJSON = types.StringValue("{}")
-	} else {
-		model.InputsJSON = types.StringNull()
 	}
 
 	if len(resp.Filters) > 0 {

internal/resource/insight.go

@@ -12,6 +12,7 @@ import (
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/boolplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/int64planmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/resource/schema/planmodifier"
+	"github.com/hashicorp/terraform-plugin-framework/resource/schema/stringplanmodifier"
 	"github.com/hashicorp/terraform-plugin-framework/types"
 	"github.com/posthog/terraform-provider/internal/httpclient"
 	"github.com/posthog/terraform-provider/internal/resource/core"
@@ -56,7 +57,11 @@ func (o InsightOps) Schema() schema.Schema {
 			},
 			"derived_name": schema.StringAttribute{
 				Optional:            true,
-				MarkdownDescription: "Insight derived name.",
+				Computed:            true,
+				MarkdownDescription: "Insight derived name. This is auto-generated by PostHog when the name is not set.",
+				PlanModifiers: []planmodifier.String{
+					stringplanmodifier.UseStateForUnknown(),
+				},
 			},
 			"description": schema.StringAttribute{
 				Optional:            true,