Graceful shutdown

[mkleczek]

Right now PostgREST does not wait for in-flight requests to finish upon shutdown (ie. SIGTERM).

It would be good if we used Warp shutdownHandler to handle shutdown gracefully.

This is crucial to handle upgrades in near-zero downtime fashion.

[steve-chavez]

Right now PostgREST does not wait for in-flight requests to finish upon shutdown (ie. SIGTERM).

I believe we do? Although once SIGTERM is done we stop accepting new requests.

It would be great to have a test corroborating the above.

This looks related to #4580

[mkleczek]

Right now PostgREST does not wait for in-flight requests to finish upon shutdown (ie. SIGTERM).

I believe we do? Although once SIGTERM is done we stop accepting new requests.

I am not sure about it. According to Warp documentation:

Graceful shutdown mode is entered when the server socket is closed; see setInstallShutdownHandler for an example of how this could be done in response to a UNIX signal.

I haven't seen any code closing the listening socket or setting setGracefulShutdownTimeout .

It would be great to have a test corroborating the above.

Yeah... Seems doable: start a long running request in and then shutdown PostgREST in concurrent thread. The request should be handled fine.