Fixed bugs with Telegram notifications

Author: Patrick Banks

CHANGELOG.md

@@ -1,3 +1,9 @@
+## [1.0.1] (2021-08-03)
+
+### Bug Fixes
+
+* **trader:** Telegram notifications now work, and /info command will work without configuring a valid Chat ID.
+
 ## [1.0.0] (2021-08-01)
 
 ### Bug Fixes

app.json

@@ -43,7 +43,7 @@
         "required": false
       },
       "NOTIFIER_TELEGRAM_RECEIVER_ID": {
-        "description": "Unique identifier for the target chat or username of the target channel (in the format @channelusername)",
+        "description": "Unique identifier for the target chat (as a number) or username of the target channel (in the format @channelusername)",
         "required": false
       },
 

docs/GETTING-STARTED.md

@@ -135,7 +135,9 @@ To add new Config Vars in Heroku:
 | NOTIFIER_GMAIL_APP_PASSWORD | string | Gmail password to get notifications |
 | IS_NOTIFIER_TELEGRAM_ENABLED | true / false | Selects if Telegram will be used
 | NOTIFIER_TELEGRAM_API_KEY | string | Telegram Key for your bot (To create one follow https://core.telegram.org/bots#6-botfather)
-| NOTIFIER_TELEGRAM_RECEIVER_ID | string | Unique identifier for the target chat or username of the target channel (in the format @channelusername)
+| NOTIFIER_TELEGRAM_RECEIVER_ID | string | Unique identifier for the target chat (as a number) or username of the target channel (in the format @channelusername)
+
+*If you want to use Telegram and don't know your Chat ID, set the NOTIFIER_TELEGRAM_RECEIVER_ID to a dummy value, start the trader (you will see errors in the log), then use the /info command in Telegram and it will respond with the ID that you can use.*
 
 **Trader Features**
 | Key | Value Format | Description |

src/trader/env.ts

@@ -35,7 +35,7 @@ export function getDefault(): Readonly<any> {
         // Then talk to the @userinfobot at Telegram, and it will give you your personal receiver ID, and thats what you use for the TELEGRAM_RECEIVER_ID
         IS_NOTIFIER_TELEGRAM_ENABLED: bool({ default: false, desc: "Selects if Telegram will be used" }),
         NOTIFIER_TELEGRAM_API_KEY: str({ default: "", desc: "Telegram Key for your bot (To create one follow https://core.telegram.org/bots#6-botfather)" }),
-        NOTIFIER_TELEGRAM_RECEIVER_ID: str({ default: "", desc: "Unique identifier for the target chat or username of the target channel (in the format @channelusername)" }),
+        NOTIFIER_TELEGRAM_RECEIVER_ID: str({ default: "", desc: "Unique identifier for the target chat (as a number) or username of the target channel (in the format @channelusername)" }),
 
         // Additional configuration options for trader features
         IS_BUY_QTY_FRACTION: bool({ default: false, desc: "Uses the 'Quantity to Buy' from the NBT Hub as a fraction of your wallet balance (e.g. 0.1 is 10%)" }),

src/trader/notifiers/index.ts

@@ -1,4 +1,5 @@
 import { basename } from "path/posix"
+import logger from "../../logger"
 import { EntryType, PositionType, Signal, TradeOpen } from "../types/bva"
 import { MessageType, Notifier, NotifierMessage } from "../types/notifier"
 import { SourceType } from "../types/trader"
@@ -19,10 +20,14 @@ export default function initializeNotifiers(): Notifier {
 
 // Sends notifications on all the different channels
 export function notifyAll(notifierMessage: NotifierMessage): Promise<void> {
-    return new Promise((resolve) => {
+    return new Promise((resolve, reject) => {
         Promise.all(
             notifiers.map((notifier) => notifier.notify(notifierMessage))
         ).then(() => resolve())
+        .catch(reason => {
+            logger.error(reason)
+            reject(reason)
+        })
     })
 }
 

src/trader/notifiers/telegram.ts

@@ -3,26 +3,29 @@ import TeleBot from "telebot"
 import env from "../env"
 import { Notifier, NotifierMessage } from "../types/notifier"
 import { getTradeOpenList } from "../apis/bva"
+import logger from "../../logger"
 
 let telBot: TeleBot
 
 export default function (): Notifier {
     telBot = new TeleBot(env().NOTIFIER_TELEGRAM_API_KEY)
     telBot.on("/info", async (msg) => {
         const tradeOpenList = await getTradeOpenList().catch((reason) => {
+            logger.error(reason)
             return Promise.reject(reason)
         })
         return notify({
             content:
                 `Open Trades: ${tradeOpenList.length} - ${tradeOpenList
                     .map((tradeOpen) => tradeOpen.symbol)
-                    .join(", ")}\n` + `Channel ID: ${msg.chat.id}`,
-        })
+                    .join(", ")}\n` + `Channel Chat ID: ${msg.chat.id}`,
+        }, msg.from.id)
     })
     telBot.on("start", async () => {
         await notify({
             content: "Trader Bot started!",
         }).catch((reason) => {
+            logger.error(reason)
             return Promise.reject(reason)
         })
     })
@@ -33,21 +36,14 @@ export default function (): Notifier {
     }
 }
 
-async function notify(notifierMessage: NotifierMessage): Promise<void> {
+async function notify(notifierMessage: NotifierMessage, fromId?: string): Promise<void> {
     if (!env().IS_NOTIFIER_TELEGRAM_ENABLED || !telBot) return
 
-    return new Promise((resolve, reject) => {
-        try {
-            telBot.sendMessage(
-                env().NOTIFIER_TELEGRAM_RECEIVER_ID,
-                notifierMessage.contentHtml || notifierMessage.content,
-                {
-                    parseMode: "html",
-                }
-            )
-            resolve()
-        } catch (e) {
-            reject(e)
-        }
-    })
+    return telBot.sendMessage(
+        fromId || env().NOTIFIER_TELEGRAM_RECEIVER_ID,
+        notifierMessage.content,
+        /*{
+            parseMode: "html",
+        }*/
+    )
 }