Fixed bug save balance history after reset

Author: Patrick Banks

src/trader/http.ts

@@ -3,7 +3,7 @@ import express from "express"
 
 import logger, { loggerOutput } from "../logger"
 import env from "./env"
-import { deleteTrade, resetVirtualBalances, setVirtualWalletFunds, tradingMetaData} from "./trader"
+import { deleteBalanceHistory, deleteTrade, resetVirtualBalances, setVirtualWalletFunds, tradingMetaData} from "./trader"
 import { Dictionary } from "ccxt"
 import { BalanceHistory } from "./types/trader"
 import BigNumber from "bignumber.js"
@@ -84,15 +84,16 @@ export default function startWebserver(): http.Server {
         if (Authenticate(req, res)) {
             if (req.query.reset) {
                 const asset = req.query.reset.toString().toUpperCase()
-                let result = ""
-                for (let tradingType of Object.keys(tradingMetaData.balanceHistory)) {
-                    if (asset in tradingMetaData.balanceHistory[tradingType]) {
-                        delete tradingMetaData.balanceHistory[tradingType][asset]
+                const tradingTypes = deleteBalanceHistory(asset)
+                if (tradingTypes.length) {
+                    let result = ""
+                    for (let tradingType of tradingTypes) {
                         result += `${asset} ${tradingType} balance history has been reset.<br>`
                     }
+                    res.send(result)
+                } else {
+                    res.send(`No balance history found for ${asset}.`)
                 }
-                if (!result) result = `No balance history found for ${asset}.`
-                res.send(result)
             } else {
                 const pnl: Dictionary<Dictionary<{}>> = {}
                 const now = new Date()

src/trader/trader.ts

@@ -2071,6 +2071,19 @@ function initialiseVirtualBalances(walletType: WalletType, market: Market) {
     }
 }
 
+// Just clears the Balance History for a given coin, will clear both real and virtual
+export function deleteBalanceHistory(asset: string): string[] {
+    const result: string[] = []
+    for (let tradingType of Object.keys(tradingMetaData.balanceHistory)) {
+        if (asset in tradingMetaData.balanceHistory[tradingType]) {
+            delete tradingMetaData.balanceHistory[tradingType][asset]
+            result.push(tradingType)
+        }
+    }
+    if (result.length) saveState("virtualBalances")
+    return result
+}
+
 // Updates the running balance for the current day
 function updateBalanceHistory(tradingType: TradingType, quote: string, entryType?: EntryType, balance?: BigNumber, change?: BigNumber) {
     if (!Object.keys(tradingMetaData.balanceHistory).includes(tradingType)) tradingMetaData.balanceHistory[tradingType] = {}