Skip to content

Commit 586dc66

Browse files
authored
Fix: leaderboard mobile responsiveness (#197)
* fix: add fallback image for feed list * fix: leaderboard not being properly responsive * feat: add dev frontend command * fix: new dev command * fix: remove extra margin on table when on mobile
1 parent 7667141 commit 586dc66

File tree

4 files changed

+8
-6
lines changed

4 files changed

+8
-6
lines changed

apps/app/src/components/FeedList.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,12 @@ const FeedList = () => {
2828
>
2929
<div className="flex items-center border border-1 border-neutral-200 rounded-md justify-center gap-3 py-2 px-3">
3030
<img
31-
src={feed?.config.image}
32-
alt={feed?.config.name}
31+
src={feed?.config.image || "/images/feed-image.png"}
32+
alt={feed?.config.name || "Feed image"}
3333
className="w-[50px] h-[50px] aspect-square object-cover"
34-
width={40}
35-
height={40}
34+
onError={(e) => {
35+
e.currentTarget.src = "/images/feed-image.png";
36+
}}
3637
/>
3738
<div className="flex flex-col w-full">
3839
<span className="text-[16px] ">{feed.name}</span>

apps/app/src/components/leaderboard/LeaderboardFilters.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export function LeaderboardFilters({
4646
timeDropdownRef,
4747
}: LeaderboardFiltersProps) {
4848
return (
49-
<div className="flex flex-col md:flex-row max-w-[400px] md:max-w-screen-xl md:w-full mx-auto justify-between items-center mb-6 gap-4 px-4 py-8">
49+
<div className="flex flex-col md:flex-row max-w-[400px] md:max-w-screen-xl md:w-full mx-auto justify-between items-center mb-6 gap-4 py-8">
5050
<div className="relative w-full md:w-auto">
5151
<Search className="absolute left-3 top-1/2 transform -translate-y-1/2 text-[#a3a3a3] h-4 w-4" />
5252
<input

apps/app/src/components/leaderboard/LeaderboardTable.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ export function LeaderboardTable({
2525
hasData,
2626
}: LeaderboardTableProps) {
2727
return (
28-
<div className="overflow-y-auto max-w-[368px] md:max-w-screen-xl md:w-full mx-auto scrollbar-thin scrollbar-thumb-gray-300 scrollbar-track-transparent">
28+
<div className="overflow-y-auto max-w-[calc(100vw-32px)] md:max-w-screen-xl md:w-full mx-auto scrollbar-thin scrollbar-thumb-gray-300 scrollbar-track-transparent">
2929
<div className="relative">
3030
<Table className="w-full border-collapse">
3131
<TableHeader className="sticky top-0 bg-white z-10">

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
"scripts": {
1313
"dev": "./scripts/dev.sh",
1414
"dev:fresh": "./scripts/dev.sh --fresh",
15+
"dev:frontend": "turbo run dev --filter=@curatedotfun/app",
1516
"build": "turbo run build",
1617
"start": "docker-compose --profile prod up -d --build postgres_prod && docker-compose --profile prod run --rm db-init-prod && docker-compose --profile prod up -d --build app",
1718
"test": "docker-compose --profile test up -d postgres_test && docker-compose --profile test run --rm db-init-test && turbo run test --filter=@curatedotfun/api || true && docker-compose --profile test down -v",

0 commit comments

Comments
 (0)