Skip to content

Commit dc44cc7

Browse files
committed
nitpicks
1 parent 316a546 commit dc44cc7

File tree

3 files changed

+14
-16
lines changed

3 files changed

+14
-16
lines changed

apps/app/src/components/feed/EditFeedForm.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
import { type FeedConfig } from "@curatedotfun/types";
22
import { zodResolver } from "@hookform/resolvers/zod";
3+
import { debounce, isEqual } from "lodash-es";
34
import {
4-
useEffect,
5-
useState,
6-
useCallback,
7-
useRef,
85
forwardRef,
6+
useCallback,
7+
useEffect,
98
useImperativeHandle,
9+
useRef,
10+
useState,
1011
} from "react";
11-
import { debounce } from "lodash-es";
1212
import { useFieldArray, useForm } from "react-hook-form";
1313
import { Form } from "../ui/form";
1414
import {
1515
BasicFieldsSection,
16-
SourcesSection,
17-
StreamSettingsSection,
18-
ModerationSection,
1916
// IngestionSection,
2017
FeedConfigFormSchema,
18+
ModerationSection,
19+
SourcesSection,
20+
StreamSettingsSection,
2121
type FormValues,
2222
} from "./form";
2323

@@ -177,7 +177,7 @@ export const EditFeedForm = forwardRef<EditFeedFormRef, EditFeedFormProps>(
177177
// Only update sources if they exist in the form
178178
if (
179179
values.sources !== undefined &&
180-
JSON.stringify(values.sources) !== JSON.stringify(config.sources)
180+
!isEqual(values.sources, config.sources)
181181
) {
182182
updatedConfig.sources = values.sources;
183183
}

apps/app/src/hooks/use-edit-feed.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ export function useEditFeed(feedId: string): {
122122
try {
123123
await deleteFeedMutation.mutateAsync();
124124
toast({ title: "Success", description: "Feed deleted successfully." });
125-
navigate({ to: "/" });
125+
navigate({ to: "/profile/my-feeds" });
126126
} catch (error: unknown) {
127127
const err = error instanceof Error ? error : new Error(String(error));
128128
console.error("Failed to delete feed:", err);

apps/app/src/routes/_layout/profile/_tabs/settings/_tabs.tsx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,10 @@ function SettingsTabsAreaLayout() {
5151
}
5252
};
5353

54+
const currentTab = getCurrentTab();
55+
5456
return (
55-
<Tabs
56-
value={getCurrentTab()}
57-
onValueChange={handleTabChange}
58-
className="w-full"
59-
>
57+
<Tabs value={currentTab} onValueChange={handleTabChange} className="w-full">
6058
<TabsList className="w-full justify-start">
6159
{navigationItems.map((item) => (
6260
<TabsTrigger key={item.value} value={item.value}>
@@ -65,7 +63,7 @@ function SettingsTabsAreaLayout() {
6563
))}
6664
</TabsList>
6765

68-
<TabsContent value={getCurrentTab()} className="mt-6">
66+
<TabsContent value={currentTab} className="mt-6">
6967
<Outlet />
7068
</TabsContent>
7169
</Tabs>

0 commit comments

Comments
 (0)