First Release Candidate of PowerDNS Recursor 5.3.0

[omoerbeek]

https://blog.powerdns.com/powerdns-recursor-5.3.0-rc1-released

[paddg]

Hi.

Report on build problems with Suse SLES15-SP5

Source-Code: pdns-recursor-5.3.0-rc1.tar.xz

First try:

[   50s] checking for curl... no
[   50s] configure: error: curl is missing and you don't have .//effective_tld_names.dat. Install curl or download sources from www.powerdns.com
[   50s] error: Bad exit status from /var/tmp/rpm-tmp.BSA8mq (%build)

I added BuildRequires: curl in the spec File, but I'm wondering why we need curl for an offline build.

Second try:

[   58s] Making all in rec-rust-lib
[   58s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib'
[   58s] (cd . && /usr/bin/python3 generate.py)
[   58s] Generate cwd: /home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib
[   58s] Generate srcdir: . = /home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib
[   58s] Generate gendir: . = /home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib
[   58s] Traceback (most recent call last):
[   58s]   File "generate.py", line 857, in <module>
[   58s]     generate()
[   58s]   File "generate.py", line 844, in generate
[   58s]     Path(gendir, 'rust', 'librecrust.a').unlink(True)
[   58s] TypeError: unlink() takes 1 positional argument but 2 were given
[   58s] make[2]: *** [Makefile:601: cxxsettings-generated.cc] Error 1
[   58s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib'
[   58s] make[1]: *** [Makefile:1921: all-recursive] Error 1
[   58s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1'
[   58s] make: *** [Makefile:1455: all] Error 2
[   58s] error: Bad exit status from /var/tmp/rpm-tmp.gBsXqQ (%build)

I replaced python3:

- BuildRequires: python3
+ BuildRequires: python311

However, I would feel better if it worked with python3 (Python 3.6.15), as it is officially recommended and supported by SLES15-SP5.

Third try:

[   84s]   cargo:warning=/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/sources/recrust/src/misc.rs.cc:938:64:   required from here
[   84s]   cargo:warning=/usr/include/c++/7/bits/shared_ptr_base.h:1082:25: error: invalid application of 'sizeof' to incomplete type 'Logr::Logger'
[   84s]   cargo:warning=    static_assert( sizeof(_Yp) > 0, "incomplete type" );
[   84s]   cargo:warning=                         ^
[   84s] 
[   84s]   --- stderr
[   84s] 
[   84s]   CXX include path:
[   84s]     /home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/include
[   84s]     /home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/crate
[   84s] 
[   84s] 
[   84s]   error occurred in cc-rs: command did not execute successfully (status code exit status: 1): LC_ALL="C" "g++" "-std=c++17" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/include" "-I" "/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/crate" "-Isrc" "-I../.." "-std=c++17" "-fPIE" "-DPIE" "-U_FORTIFY_SOURCE" "-D_FORTIFY_SOURCE=2" "--param" "ssp-buffer-size=4" "-fstack-protector" "-Wall" "-Wextra" "-Wshadow" "-Wmissing-declarations" "-Wredundant-decls" "-fvisibility=hidden" "-g" "-O2" "-fmessage-length=0" "-grecord-gcc-switches" "-O2" "-Wall" "-D_FORTIFY_SOURCE=2" "-fstack-protector-strong" "-funwind-tables" "-fasynchronous-unwind-tables" "-fstack-clash-protection" "-g" "-o" "/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/764284a759419a18-misc.rs.o" "-c" "/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust/./target/release/build/recrust-b7fb5e0f4d174c57/out/cxxbridge/sources/recrust/src/misc.rs.cc"
[   84s] 
[   84s] 
[   84s] warning: build failed, waiting for other jobs to finish...
[   91s] make[2]: *** [Makefile:591: librecrust.a] Error 101
[   91s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1/rec-rust-lib/rust'
[   91s] make[1]: *** [Makefile:1921: all-recursive] Error 1
[   91s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/pdns-recursor-5.3.0-rc1'
[   91s] make: *** [Makefile:1455: all] Error 2
[   91s] error: Bad exit status from /var/tmp/rpm-tmp.GTklwm (%build)

I have no idea what's going wrong here (invalid application of 'sizeof' to incomplete type 'Logr::Logger'). Attached is the entire build.log.

Winfried

[omoerbeek]

I'm taking a look.

[omoerbeek]

I fixed the curl thing locally. Did not look at the Python thing yet.
Looking at your build log, configure decided to use gcc7, while gcc13 is also being installed and thus available. That is suspicious.

[paddg]

Thanks, I tried that, but it wasn't successful.
build.log

[omoerbeek]

This might work. I will continue working on this Monday.

patch.txt

[paddg]

Hello Otto,

This might work.

Yes, I can confirm the patch.txt works!

I tried also your PR "rec: Path.unlink(True) requires python 3.8, rewrite so it works on older versions". It works as well (with Python 3.6.15).

All that's left is the curl thing.

Thanks!

[omoerbeek]

Good! #16010 fixes the curl thing. It will be backported along wit the two other build related fixes.

[paddg]

Thank you!