PowerDNS Recursor 5.3.0 Released

[omoerbeek]

https://blog.powerdns.com/powerdns-recursor-5.3.0-released

[paddg]

Hi, the build on Suse (SLES15-SP5) fails:

[   94s] error: cannot find attribute `serde` in this scope
[   94s]   --> src/lib.rs:67:7
[   94s]    |
[   94s] 67 |     #[serde(deny_unknown_fields)]
[   94s]    |       ^^^^^
[   94s]    |
[   94s]    = note: `serde` is in scope, but it is a crate, not an attribute

recursor-5.3.0.build.log
pdns-recursor.spec

Would you please take a look? Did I do something wrong?

[omoerbeek]

Will do so first thing tomorrow.

[omoerbeek]

Looking at the versions of crates used in the log it looks like you are not using the versions specified in the Cargo.lock file. And indeed, after a cargo update in rec-rust-lib/rust I can reproduce the error in a development environment.

I'll investigate further how to fix that, but I recommend using the shipped Cargo.lock versions, as these are the same our as own built packages are using and so are well tested.

[paddg]

Thank you very much! It seems I know far too little about how Rust software is built. However, the tip helped me find the cause. My _service file in the Suse Build Service said <param name="update">true</param>:

<services>
  <service name="cargo_vendor" mode="manual">
     <param name="srctar">pdns-recursor-5.3.0.tar.xz</param>
     <param name="compression">xz</param>
     <param name="cargotoml">rec-rust-lib/rust/Cargo.toml</param>
     <param name="update">true</param>
  </service>
</services>

I've now set it to false. This allows the package to build! In my opinion, no further investigation is necessary on your side.

[omoerbeek]

Very good!

Some investigation regarding this failure is still needed, as we normally update dependencies for the new release cycle. I know now that will be more than just running cargo update and committing the resulting Cargo.lock file.

[omoerbeek]

See #16101 In PowerDNS/pdns;

[paddg]

Cool, thanks! We will still stick with <param name="update">false</param>, just to be safe.