chore: centralize duplicate function

Signed-off-by: jaapschoutenalliander <[email protected]>

Author: jaapschoutenalliander

src/power_grid_model_ds/_core/model/graphs/models/base.py

@@ -16,6 +16,7 @@
     MissingNodeError,
     NoPathBetweenNodes,
 )
+from power_grid_model_ds._core.model.utils import _get_branch3_branches
 
 if TYPE_CHECKING:
     from power_grid_model_ds._core.model.grids.base import Grid
@@ -421,21 +422,3 @@ def _find_fundamental_cycles(self) -> list[list[int]]: ...
 
     @abstractmethod
     def _all_branches(self) -> Generator[tuple[int, int], None, None]: ...
-
-
-def _get_branch3_branches(branch3: Branch3Array) -> BranchArray:
-    node_1 = branch3.node_1.item()
-    node_2 = branch3.node_2.item()
-    node_3 = branch3.node_3.item()
-
-    status_1 = branch3.status_1.item()
-    status_2 = branch3.status_2.item()
-    status_3 = branch3.status_3.item()
-
-    branches = BranchArray.zeros(3)
-    branches.from_node = [node_1, node_1, node_2]
-    branches.to_node = [node_2, node_3, node_3]
-    branches.from_status = [status_1, status_1, status_2]
-    branches.to_status = [status_2, status_3, status_3]
-
-    return branches

src/power_grid_model_ds/_core/model/utils.py

@@ -0,0 +1,22 @@
+# SPDX-FileCopyrightText: Contributors to the Power Grid Model project <[email protected]>
+#
+# SPDX-License-Identifier: MPL-2.0
+from power_grid_model_ds._core.model.arrays.pgm_arrays import Branch3Array, BranchArray
+
+
+def _get_branch3_branches(branch3: Branch3Array) -> BranchArray:
+    node_1 = branch3.node_1.item()
+    node_2 = branch3.node_2.item()
+    node_3 = branch3.node_3.item()
+
+    status_1 = branch3.status_1.item()
+    status_2 = branch3.status_2.item()
+    status_3 = branch3.status_3.item()
+
+    branches = BranchArray.zeros(3)
+    branches.from_node = [node_1, node_1, node_2]
+    branches.to_node = [node_2, node_3, node_3]
+    branches.from_status = [status_1, status_1, status_2]
+    branches.to_status = [status_2, status_3, status_3]
+
+    return branches

src/power_grid_model_ds/_core/visualizer/parsers.py

@@ -6,6 +6,7 @@
 
 from power_grid_model_ds._core.model.arrays.base.array import FancyArray
 from power_grid_model_ds._core.model.grids.base import Grid
+from power_grid_model_ds._core.model.utils import _get_branch3_branches
 from power_grid_model_ds.arrays import Branch3Array, BranchArray, NodeArray
 
 
@@ -41,7 +42,7 @@ def parse_branch3_array(branches: Branch3Array, group: Literal["transformer"]) -
     parsed_branches = []
     columns = branches.columns
     for branch in branches:
-        for branch_ in _branch3_to_branches(branch):
+        for branch_ in _get_branch3_branches(branch):
             cyto_elements = {"data": _array_to_dict(branch_, columns)}
             cyto_elements["data"].update(
                 {
@@ -56,24 +57,6 @@ def parse_branch3_array(branches: Branch3Array, group: Literal["transformer"]) -
     return parsed_branches
 
 
-def _branch3_to_branches(branch3: Branch3Array) -> BranchArray:
-    node_1 = branch3.node_1.item()
-    node_2 = branch3.node_2.item()
-    node_3 = branch3.node_3.item()
-
-    status_1 = branch3.status_1.item()
-    status_2 = branch3.status_2.item()
-    status_3 = branch3.status_3.item()
-
-    branches = BranchArray.zeros(3)
-    branches.from_node = [node_1, node_1, node_2]
-    branches.to_node = [node_2, node_3, node_3]
-    branches.from_status = [status_1, status_1, status_2]
-    branches.to_status = [status_2, status_3, status_3]
-
-    return branches
-
-
 def parse_branch_array(branches: BranchArray, group: Literal["line", "link", "transformer"]) -> list[dict[str, Any]]:
     """Parse the branch array."""
     parsed_branches = []