Skip to content

Commit 72e3c61

Browse files
committed
switch extended arrays
Signed-off-by: Thijs Baaijen <[email protected]>
1 parent 6bebd28 commit 72e3c61

File tree

3 files changed

+23
-30
lines changed

3 files changed

+23
-30
lines changed

tests/fixtures/arrays.py

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import numpy as np
66
from numpy._typing import NDArray
77

8+
from power_grid_model_ds._core.model.arrays import LineArray, NodeArray
89
from power_grid_model_ds._core.model.arrays.base.array import FancyArray
910
from power_grid_model_ds._core.model.dtypes.sensors import NDArray3
1011

@@ -36,15 +37,6 @@ class DifferentFancyTestArray(FancyArray):
3637
test_bool2: NDArray[np.bool_]
3738

3839

39-
class ExtendedFancyTestArray(FancyTestArray):
40-
"""Test array with some extended attributes"""
41-
42-
test_int2: NDArray[np.int64]
43-
test_float2: NDArray[np.float64]
44-
test_str2: NDArray[np.str_]
45-
test_bool2: NDArray[np.bool_]
46-
47-
4840
class LongColumnNameFancyTestArray(FancyArray):
4941
"""Test array with a very long column name"""
5042

@@ -66,3 +58,19 @@ class FancyTestArray3(FancyArray):
6658

6759
test_float1: NDArray3[np.float64]
6860
test_float2: NDArray3[np.float64]
61+
62+
63+
class ExtendedNodeArray(NodeArray):
64+
"""Extends the node array with an output value"""
65+
66+
_defaults = {"u": 0}
67+
68+
u: NDArray[np.float64]
69+
70+
71+
class ExtendedLineArray(LineArray):
72+
"""Extends the line array with an output value"""
73+
74+
_defaults = {"i_from": 0}
75+
76+
i_from: NDArray[np.float64]

tests/integration/loadflow/test_power_grid_model.py

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,27 +23,12 @@
2323
)
2424
from power_grid_model_ds._core.model.arrays.pgm_arrays import TransformerTapRegulatorArray
2525
from power_grid_model_ds._core.model.grids.base import Grid
26+
from tests.fixtures.arrays import ExtendedLineArray, ExtendedNodeArray
2627
from tests.unit.model.grids.test_custom_grid import CustomGrid
2728

2829
# pylint: disable=missing-function-docstring,missing-class-docstring
2930

3031

31-
class ExtendedNodeArray(NodeArray):
32-
"""Extends the node array with an output value"""
33-
34-
_defaults = {"u": 0}
35-
36-
u: NDArray[np.float64]
37-
38-
39-
class ExtendedLineArray(LineArray):
40-
"""Extends the line array with an output value"""
41-
42-
_defaults = {"i_from": 0}
43-
44-
i_from: NDArray[np.float64]
45-
46-
4732
def test_load_flow_on_random():
4833
"""Tests the power flow on a randomly configured grid"""
4934
grid_generator = RadialGridGenerator(grid_class=Grid, nr_nodes=5, nr_sources=1, nr_nops=0)

tests/unit/model/arrays/test_array.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11,10 +11,10 @@
1111

1212
from power_grid_model_ds._core import fancypy as fp
1313
from power_grid_model_ds._core.model.arrays.base.array import FancyArray
14-
from power_grid_model_ds._core.model.arrays.pgm_arrays import TransformerArray
14+
from power_grid_model_ds._core.model.arrays.pgm_arrays import LineArray, TransformerArray
1515
from power_grid_model_ds._core.model.constants import EMPTY_ID, empty
1616
from tests.conftest import FancyTestArray
17-
from tests.fixtures.arrays import ExtendedFancyTestArray, FancyTestArray3
17+
from tests.fixtures.arrays import ExtendedLineArray, FancyTestArray3
1818

1919
# pylint: disable=missing-function-docstring
2020

@@ -292,7 +292,7 @@ def test_overflow_value():
292292

293293

294294
def test_from_extended_array():
295-
extended_array = ExtendedFancyTestArray.zeros(2)
296-
array = FancyTestArray.from_extended(extended_array)
297-
assert not isinstance(array, ExtendedFancyTestArray)
295+
extended_array = ExtendedLineArray.zeros(2)
296+
array = LineArray.from_extended(extended_array)
297+
assert not isinstance(array, ExtendedLineArray)
298298
assert_array_equal(array.data, extended_array[array.columns])

0 commit comments

Comments
 (0)