make substation_nodes optional

Author: vincentkoppen

src/power_grid_model_ds/_core/model/graphs/models/base.py

@@ -248,9 +248,9 @@ def get_all_paths(self, ext_start_node_id: int, ext_end_node_id: int) -> list[li
 
         return [self._internals_to_externals(path) for path in internal_paths]
 
-    def get_components(self, substation_nodes: list[int]) -> list[list[int]]:
+    def get_components(self, substation_nodes: list[int] | None = None) -> list[list[int]]:
         """Returns all separate components when the substation_nodes are removed of the graph as lists"""
-        if len(substation_nodes):
+        if substation_nodes:
             warnings.warn(
                 message="""
 get_components: substation_nodes argument is deprecated and will be removed in a future release.
@@ -262,6 +262,7 @@ def get_components(self, substation_nodes: list[int]) -> list[list[int]]:
                 category=DeprecationWarning,
                 stacklevel=2,
             )
+        substation_nodes = substation_nodes or []
         with self.tmp_remove_nodes(substation_nodes):
             internal_components = self._get_components()
         return [self._internals_to_externals(component) for component in internal_components]

src/power_grid_model_ds/_core/model/grids/helpers.py

@@ -46,7 +46,8 @@ def set_feeder_ids(grid: "Grid"):
     """
     _reset_feeder_ids(grid)
     feeder_node_ids = grid.node.filter(node_type=NodeType.SUBSTATION_NODE)["id"]
-    components = grid.graphs.active_graph.get_components(feeder_node_ids)
+    with grid.graphs.active_graph.tmp_remove_nodes(feeder_node_ids):
+        components = grid.graphs.active_graph.get_components()
     for component_node_ids in components:
         component_branches = _get_active_component_branches(grid, component_node_ids)
 

tests/unit/model/grids/test_grid_search.py

@@ -57,9 +57,9 @@ def test_get_branches_in_path_empty_path(self, basic_grid):
 
 
 def test_component_three_winding_transformer(grid_with_3wt):
-    component_list = grid_with_3wt.graphs.active_graph.get_components(
-        grid_with_3wt.node.filter(node_type=NodeType.SUBSTATION_NODE.value).id
-    )
+    substation_nodes = grid_with_3wt.node.filter(node_type=NodeType.SUBSTATION_NODE.value).id
+    with grid_with_3wt.graphs.active_graph.tmp_remove_nodes(substation_nodes):
+        component_list = grid_with_3wt.graphs.active_graph.get_components()
 
     # check the components are as expected
     # use sets to make sure the order of the components is not important