Skip to content

Add type hints to GraphModel properties and fix documentation #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2025
Merged

Add type hints to GraphModel properties and fix documentation #111

merged 1 commit into from
Nov 12, 2025
+5 −5

Conversation

@svenvdvoort
Copy link
Member

@svenvdvoort svenvdvoort commented Nov 12, 2025

Changes proposed in this PR include:

Here you can elaborate on the chosen solution strategy, which changes did you make and which goal do they serve. Perhaps also which things are you still unsure of.

  • Add type hints to nr_nodes and nr_branches properties of GraphModels
  • Fix incorrect documentation for BaseGraphModel.get_components()

Could you please pay extra attention to the points below when reviewing the PR:

Checks

  • If changes are related to CI/CD, are they verified via a manual run on this branch?

Thijss
Thijss approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@Thijss Thijss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@svenvdvoort svenvdvoort merged commit 54a4061 into main Nov 12, 2025
15 checks passed
@svenvdvoort svenvdvoort deleted the fix/types-graphmodel branch November 12, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thijss Thijss Thijss approved these changes

@vincentkoppen vincentkoppen vincentkoppen approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@svenvdvoort @Thijss @vincentkoppen