From 4dc9cdefce33d2bde709f7c3ceddbb25ccaf5cd1 Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 16:53:34 +0200 Subject: [PATCH 1/7] Fix pre-release downloads Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 6 +++++- .github/workflows/ci.yml | 23 +++++++---------------- 2 files changed, 12 insertions(+), 17 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index 30e4258..5de35fe 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -27,8 +27,10 @@ concurrency: group: ${{ github.workflow }}-${{ github.ref }}-main cancel-in-progress: true -jobs: +outputs: + tag: ${{ jobs.github-release.outputs.tag }} +jobs: build-python: runs-on: ubuntu-latest outputs: @@ -101,6 +103,8 @@ jobs: permissions: contents: write runs-on: ubuntu-latest + outputs: + tag: ${{ steps.tag.outputs.tag }} steps: - name: Setup Python 3.13 uses: actions/setup-python@v5 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4f46c26..ef80b6f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -64,22 +64,13 @@ jobs: if: (github.event_name == 'workflow_dispatch' && inputs.create_release) || github.event_name == 'push' steps: - - name: Download assets from GitHub release - uses: robinraju/release-downloader@v1 - with: - repository: ${{ github.repository }} - # download the latest release - latest: true - # don't download pre-releases - preRelease: false - fileName: "*" - # don't download GitHub-generated source tar and zip files - tarBall: false - zipBall: false - # create a directory to store the downloaded assets - out-file-path: assets-to-publish - # don't extract downloaded files - extract: false + - name: Download assets from latest GitHub release using gh CLI + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: | + mkdir -p assets-to-publish + release_tag="${{ needs.build-test-release.outputs.tag }}" + gh release download "$release_tag" --repo "$GITHUB_REPOSITORY" --dir assets-to-publish - name: List downloaded assets run: ls -la assets-to-publish From cce4d3a9dadeb7931434aeb00b28ee1040017c9b Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 16:57:13 +0200 Subject: [PATCH 2/7] put outputs under workflow_call Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index 5de35fe..9c9803d 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -14,6 +14,9 @@ on: description: Create a (pre-)release when CI passes default: false required: false + outputs: + tag: ${{ jobs.github-release.outputs.tag }} + # run this workflow manually from the Actions tab workflow_dispatch: inputs: @@ -27,9 +30,6 @@ concurrency: group: ${{ github.workflow }}-${{ github.ref }}-main cancel-in-progress: true -outputs: - tag: ${{ jobs.github-release.outputs.tag }} - jobs: build-python: runs-on: ubuntu-latest From 4b6e34ec5f9f9c15bf9197a0477fe49c38b9ecb6 Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 16:59:36 +0200 Subject: [PATCH 3/7] sue value/description Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index 9c9803d..6d739cc 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -15,7 +15,9 @@ on: default: false required: false outputs: - tag: ${{ jobs.github-release.outputs.tag }} + tag: + description: "The created release tag" + value: ${{ jobs.github-release.outputs.tag }} # run this workflow manually from the Actions tab workflow_dispatch: From da8bca7ef8d3892e900edd44bd5473fd59102175 Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 17:00:43 +0200 Subject: [PATCH 4/7] fix indentation issue Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index 6d739cc..b8e0445 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -14,10 +14,10 @@ on: description: Create a (pre-)release when CI passes default: false required: false - outputs: - tag: - description: "The created release tag" - value: ${{ jobs.github-release.outputs.tag }} + outputs: + tag: + description: "The created release tag" + value: ${{ jobs.github-release.outputs.tag }} # run this workflow manually from the Actions tab workflow_dispatch: From da714dd607080cce0a4175b20672cdbd04953186 Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 17:01:34 +0200 Subject: [PATCH 5/7] disable test needs for now Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index b8e0445..36ad5f7 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -101,7 +101,7 @@ jobs: github-release: needs: - build-python - - tests +# - tests permissions: contents: write runs-on: ubuntu-latest From 8d57ab152281fe6da27d8be9f9eebe75ee9c40a8 Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 17:07:40 +0200 Subject: [PATCH 6/7] disable mac & windows for now Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index 36ad5f7..eef6959 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -72,7 +72,8 @@ jobs: needs: build-python strategy: matrix: - os: [ubuntu-latest, macos-latest, windows-latest] +# os: [ ubuntu-latest, macos-latest, windows-latest ] + os: [ubuntu-latest] python: ["3.11", "3.12", "3.13"] fail-fast: false runs-on: ${{ matrix.os }} @@ -101,7 +102,7 @@ jobs: github-release: needs: - build-python -# - tests + - tests permissions: contents: write runs-on: ubuntu-latest From a24eaf722672b024d3747802b13d980cfabb191e Mon Sep 17 00:00:00 2001 From: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> Date: Mon, 16 Jun 2025 17:12:35 +0200 Subject: [PATCH 7/7] enable mac & windows again Signed-off-by: Thijs Baaijen <13253091+Thijss@users.noreply.github.com> --- .github/workflows/build-test-release.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/build-test-release.yml b/.github/workflows/build-test-release.yml index eef6959..0944853 100644 --- a/.github/workflows/build-test-release.yml +++ b/.github/workflows/build-test-release.yml @@ -72,8 +72,7 @@ jobs: needs: build-python strategy: matrix: -# os: [ ubuntu-latest, macos-latest, windows-latest ] - os: [ubuntu-latest] + os: [ ubuntu-latest, macos-latest, windows-latest ] python: ["3.11", "3.12", "3.13"] fail-fast: false runs-on: ${{ matrix.os }}