Add Grid.from_pgm_data #77
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/add-from-pgm-data
branch
from
c5b72e6 to
d92746c
Compare
Member
|
The PowerGridModelInterface already supports this conversion, see https://power-grid-model-ds.readthedocs.io/en/stable/examples/pgm/basic_pgm_examples.html#create-grid-from-input-data-example So could we reuse these functions or do they suffice in the current implementation? |
Signed-off-by: Thijs Baaijen <[email protected]>
Member
Author
|
As @jaapschoutenalliander, functionality is already available. PR can be closed |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a helper method that simplifies creating a grid from PGM input data
also made
array_equal_with_nanpublic and moved tomiscmodule