Add res_output_3ph for shunt, motor, ward

Signed-off-by: furqan463 <[email protected]>

Author: furqan463

src/power_grid_model_io/converters/pandapower_converter.py

@@ -360,15 +360,18 @@ def _create_output_data_3ph(self):
         Furthermore, creates a global node lookup table, which stores nodes' voltage magnitude per unit and the voltage
         angle in degrees
         """
-        # TODO create output_data_3ph for remaining components
+        # TODO create output_data_3ph for trafos3w
         # Although Pandapower itself did not implmenet res_shunt_3ph
         # Since results are avaiable in PGM output, these should be converted.
         self._pp_buses_output_3ph()
         self._pp_lines_output_3ph()
         self._pp_ext_grids_output_3ph()
         self._pp_loads_output_3ph()
+        self._pp_shunts_output_3ph()
         self._pp_trafos_output_3ph()
         self._pp_sgens_output_3ph()
+        self._pp_ward_output_3ph()
+        self._pp_motor_output_3ph()
         self._pp_asym_gens_output_3ph()
         self._pp_asym_loads_output_3ph()
 
@@ -2154,6 +2157,68 @@ def _pp_loads_output_3ph(self):
             pp_component_name="load", load_id_names=load_id_names
         )
 
+    def _pp_ward_output_3ph(self):
+        # TODO: Create Unit tests
+        load_id_names = ["ward_const_power_load", "ward_const_impedance_load"]
+        if (
+            ComponentType.sym_load not in self.pgm_output_data
+            or self.pgm_output_data[ComponentType.sym_load].size == 0
+            or ("ward", load_id_names[0]) not in self.idx
+        ):
+            return
+
+        # TODO Find a better way for mapping vm_pu from bus
+        # accumulated_loads["vm_pu"] = np.nan
+        # Store the results, while assuring that we are not overwriting any data
+        assert "res_ward_3ph" not in self.pp_output_data
+        self.pp_output_data["res_ward_3ph"] = self._pp_load_result_accumulate(
+            pp_component_name="ward", load_id_names=load_id_names
+        )
+
+    def _pp_motor_output_3ph(self):
+        # TODO: Create unit tests
+        load_id_names = ["motor_load"]
+
+        assert "res_motor_3ph" not in self.pp_output_data
+
+        if (
+            ComponentType.sym_load not in self.pgm_output_data
+            or self.pgm_output_data[ComponentType.sym_load].size == 0
+            or ("motor", load_id_names[0]) not in self.idx
+        ):
+            return
+
+        # Store the results, while assuring that we are not overwriting any data
+        assert "res_motor" not in self.pp_output_data
+        self.pp_output_data["res_motor_3ph"] = self._pp_load_result_accumulate(
+            pp_component_name="motor", load_id_names=load_id_names
+        )
+
+    def _pp_shunts_output_3ph(self):
+        """
+        This function converts a power-grid-model Shunt output array to a Shunt Dataframe of PandaPower.
+
+        Returns:
+            a PandaPower Dataframe for the Shunt component
+        """
+        # TODO: create unit tests for the function
+        assert "res_shunt_3ph" not in self.pp_output_data
+
+        if ComponentType.shunt not in self.pgm_output_data or self.pgm_output_data[ComponentType.shunt].size == 0:
+            return
+
+        pgm_output_shunts = self.pgm_output_data[ComponentType.shunt]
+
+        pp_output_shunts = pd.DataFrame(
+            columns=["p_mw", "q_mvar", "vm_pu"],
+            index=self._get_pp_ids("shunt", pgm_output_shunts["id"]),
+        )
+        pp_output_shunts["p_mw"] = pgm_output_shunts["p"].sum() * 1e-6
+        pp_output_shunts["q_mvar"] = pgm_output_shunts["q"].sum() * 1e-6
+        # TODO Find a better way for mapping vm_pu from bus
+        # pp_output_shunts["vm_pu"] = np.nan
+        self.pp_output_data["res_shunt_3ph"] = pp_output_shunts
+
     def _pp_asym_loads_output_3ph(self):
         """
         This function converts a power-grid-model Asymmetrical Load output array to an Asymmetrical Load Dataframe of

tests/unit/converters/test_pandapower_converter_output.py

@@ -54,7 +54,7 @@ def test_create_output_data_3ph():
     PandaPowerConverter._create_output_data_3ph(self=converter)  # type: ignore
 
     # Assert
-    assert len(converter.method_calls) == 8
+    assert len(converter.method_calls) == 11
     converter._pp_buses_output_3ph.assert_called_once_with()
     converter._pp_lines_output_3ph.assert_called_once_with()
     converter._pp_ext_grids_output_3ph.assert_called_once_with()

tests/validation/converters/test_pandapower_converter_output.py

@@ -311,20 +311,15 @@ def _get_total_powers_3ph(net):
     else:
         s_motor = complex128()
 
-    if "res_ward_3ph" in net:
-        s_ward = (
-            net.res_ward_3ph.loc[:, ["p_a_mw", "p_b_mw", "p_c_mw"]].sum().sum()
-            + 1j * net.res_ward_3ph.loc[:, ["q_a_mvar", "q_b_mvar", "q_c_mvar"]].sum().sum()
-        )
+    if ("res_ward_3ph" in net) and (not net.res_ward_3ph.empty):
+        s_ward = net.res_ward_3ph.loc[:, "p_mw"].sum() + 1j * net.res_ward_3ph.loc[:, "q_mvar"].sum()
     else:
         s_ward = complex128()
 
-    # TODO: enable res_shunt_3ph when implemented, right now the table exists but columns not defined.
-    # if "res_shunt_3ph" in net:
-    #    print(net.res_shunt_3ph)
-    #    s_shunt = net.res_shunt_3ph.loc[:, "p_mw"].sum() + 1j * net.res_shunt_3ph.loc[:, "q_mvar"].sum()
-    # else:
-    s_shunt = complex128()
+    if ("res_shunt_3ph" in net) and (not net.res_shunt_3ph.empty):
+        s_shunt = net.res_shunt_3ph.loc[:, "p_mw"].sum() + 1j * net.res_shunt_3ph.loc[:, "q_mvar"].sum()
+    else:
+        s_shunt = complex128()
 
     s_load = s_load_sym + s_load_asym + s_motor + s_ward + s_shunt