Skip to content

Commit 7e5aa8b

Browse files
committed
TODOs
Signed-off-by: furqan463 <[email protected]>
1 parent 8ffafd1 commit 7e5aa8b

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/power_grid_model_io/converters/pandapower_converter.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ def _parse_data(
9999
self.idx_lookup = {}
100100
self.next_idx = 0
101101

102-
# Set pandas data
102+
# Set pandapower data
103103
self.pp_input_data = data
104104

105105
# Convert
@@ -360,6 +360,9 @@ def _create_output_data_3ph(self):
360360
Furthermore, creates a global node lookup table, which stores nodes' voltage magnitude per unit and the voltage
361361
angle in degrees
362362
"""
363+
#TODO create output_data_3ph for remaining components
364+
#Although Pandapower itself did not implmenet res_shunt_3ph
365+
#Since results are avaiable in PGM output, these should be converted.
363366
self._pp_buses_output_3ph()
364367
self._pp_lines_output_3ph()
365368
self._pp_ext_grids_output_3ph()
@@ -376,6 +379,7 @@ def _create_pgm_input_nodes(self):
376379
Returns:
377380
a power-grid-model structured array for the Node component
378381
"""
382+
#TODO handle out-of-service buses, either here or in get_switch_states
379383
pp_busses = self.pp_input_data["bus"]
380384

381385
if pp_busses.empty:

0 commit comments

Comments
 (0)