Skip to content

Commit b1ed926

Browse files
committed
migrate datasettype from str to DatasetType
Signed-off-by: zhen0427 <[email protected]>
1 parent 7722f8b commit b1ed926

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

src/power_grid_model_io/converters/base_converter.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
from typing import Generic, Optional, Tuple, TypeVar
1111

1212
import structlog
13+
from power_grid_model import DatasetType
1314
from power_grid_model.data_types import Dataset, SingleDataset
1415

1516
from power_grid_model_io.data_stores.base_data_store import BaseDataStore
@@ -182,7 +183,7 @@ def _load_data(self, data: Optional[T]) -> T:
182183
raise ValueError("No data supplied!")
183184

184185
@abstractmethod # pragma: nocover
185-
def _parse_data(self, data: T, data_type: str, extra_info: Optional[ExtraInfo]) -> Dataset:
186+
def _parse_data(self, data: T, data_type: DatasetType, extra_info: Optional[ExtraInfo]) -> Dataset:
186187
pass
187188

188189
@abstractmethod # pragma: nocover

src/power_grid_model_io/converters/pandapower_converter.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ def __init__(
7777
def _parse_data(
7878
self,
7979
data: PandaPowerData,
80-
data_type: str,
80+
data_type: DatasetType,
8181
extra_info: Optional[ExtraInfo] = None,
8282
) -> Dataset:
8383
"""

src/power_grid_model_io/converters/pgm_json_converter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
from typing import Any, Dict, List, Optional, Union
1414

1515
import numpy as np
16-
from power_grid_model import initialize_array
16+
from power_grid_model import DatasetType, initialize_array
1717
from power_grid_model.data_types import ComponentList, Dataset, SingleDataset, SinglePythonDataset
1818
from power_grid_model.utils import json_deserialize, json_serialize
1919

@@ -53,7 +53,7 @@ def __init__(
5353
destination = JsonFileStore(file_path=Path(destination_file)) if destination_file else None
5454
super().__init__(source=source, destination=destination, log_level=log_level)
5555

56-
def _parse_data(self, data: StructuredData, data_type: str, extra_info: Optional[ExtraInfo]) -> Dataset:
56+
def _parse_data(self, data: StructuredData, data_type: DatasetType, extra_info: Optional[ExtraInfo]) -> Dataset:
5757
"""This function expects Structured data, which can either be a dictionary (single dataset) or a list of
5858
dictionaries (batch dataset). The structured dataset consists of components + attributes that exist within
5959
power-grid-model, but can also contain other data. If this data should be saved for later usage an extra_info

src/power_grid_model_io/converters/tabular_converter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
import numpy as np
1515
import pandas as pd
1616
import yaml
17-
from power_grid_model import initialize_array
17+
from power_grid_model import DatasetType, initialize_array
1818
from power_grid_model.data_types import Dataset
1919

2020
from power_grid_model_io.converters.base_converter import BaseConverter
@@ -90,7 +90,7 @@ def set_mapping(self, mapping: Mapping[str, Any]) -> None:
9090
if "multipliers" in mapping:
9191
self._multipliers = MultiplierMapping(cast(Multipliers, mapping["multipliers"]), logger=self._log)
9292

93-
def _parse_data(self, data: TabularData, data_type: str, extra_info: Optional[ExtraInfo]) -> Dataset:
93+
def _parse_data(self, data: TabularData, data_type: DatasetType, extra_info: Optional[ExtraInfo]) -> Dataset:
9494
"""This function parses tabular data and returns power-grid-model data
9595
9696
Args:

0 commit comments

Comments
 (0)