address sonar cloud

Signed-off-by: Nitish Bharambe <[email protected]>

Author: nitbharambe

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/topology.hpp

@@ -213,23 +213,25 @@ ComponentConnections construct_components_connections(main_model_state_c auto co
     comp_conn.branch3_connected.resize(state.comp_topo->branch3_node_idx.size());
     comp_conn.branch3_phase_shift.resize(state.comp_topo->branch3_node_idx.size());
     comp_conn.source_connected.resize(state.comp_topo->source_node_idx.size());
-    std::transform(state.components.template citer<Branch>().begin(), state.components.template citer<Branch>().end(),
-                   comp_conn.branch_connected.begin(), [](Branch const& branch) {
-                       return BranchConnected{static_cast<IntS>(branch.from_status()),
-                                              static_cast<IntS>(branch.to_status())};
-                   });
-    std::transform(state.components.template citer<Branch>().begin(), state.components.template citer<Branch>().end(),
-                   comp_conn.branch_phase_shift.begin(), [](Branch const& branch) { return branch.phase_shift(); });
-    std::transform(state.components.template citer<Branch3>().begin(), state.components.template citer<Branch3>().end(),
-                   comp_conn.branch3_connected.begin(), [](Branch3 const& branch3) {
-                       return Branch3Connected{static_cast<IntS>(branch3.status_1()),
-                                               static_cast<IntS>(branch3.status_2()),
-                                               static_cast<IntS>(branch3.status_3())};
-                   });
-    std::transform(state.components.template citer<Branch3>().begin(), state.components.template citer<Branch3>().end(),
-                   comp_conn.branch3_phase_shift.begin(), [](Branch3 const& branch3) { return branch3.phase_shift(); });
-    std::transform(state.components.template citer<Source>().begin(), state.components.template citer<Source>().end(),
-                   comp_conn.source_connected.begin(), [](Source const& source) { return source.status(); });
+    std::ranges::transform(
+        state.components.template citer<Branch>(), comp_conn.branch_connected.begin(), [](Branch const& branch) {
+            return BranchConnected{static_cast<IntS>(branch.from_status()), static_cast<IntS>(branch.to_status())};
+        });
+
+    std::ranges::transform(state.components.template citer<Branch>(), comp_conn.branch_phase_shift.begin(),
+                           [](Branch const& branch) { return branch.phase_shift(); });
+
+    std::ranges::transform(
+        state.components.template citer<Branch3>(), comp_conn.branch3_connected.begin(), [](Branch3 const& branch3) {
+            return Branch3Connected{static_cast<IntS>(branch3.status_1()), static_cast<IntS>(branch3.status_2()),
+                                    static_cast<IntS>(branch3.status_3())};
+        });
+
+    std::ranges::transform(state.components.template citer<Branch3>(), comp_conn.branch3_phase_shift.begin(),
+                           [](Branch3 const& branch3) { return branch3.phase_shift(); });
+
+    std::ranges::transform(state.components.template citer<Source>(), comp_conn.source_connected.begin(),
+                           [](Source const& source) { return source.status(); });
     return comp_conn;
 }
 

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

@@ -637,7 +637,7 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
         assert(construction_complete_);
         // clear old solvers
         reset_solvers();
-        ComponentConnections comp_conn = main_core::construct_components_connections(state_);
+        ComponentConnections const comp_conn = main_core::construct_components_connections(state_);
         // re build
         Topology topology{*state_.comp_topo, comp_conn};
         std::tie(state_.math_topology, state_.topo_comp_coup) = topology.build_topology();