fix

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/iterator_facade.hpp

@@ -45,7 +45,7 @@ class IteratorFacade {
         return (self <=> other) == std::strong_ordering::equivalent;
     }
 
-    // NOLINTNEXTLINE(cert-dcl21-cpp) // pre-increment but clang-tidy incorrectly sees this as post-increment
+    // NOLINTNEXTLINE(cert-dcl21-cpp) // pre-decrement but clang-tidy incorrectly sees this as post-decrement
     template <typename Self> constexpr std::add_lvalue_reference_t<Self> operator++(this Self& self) {
         if constexpr (requires { self.increment(); }) { // NOTE: IteratorFacade should be a friend class
             self.increment();
@@ -64,14 +64,14 @@ class IteratorFacade {
         return self;
     }
     template <typename Self>
-    constexpr std::add_const_t<std::remove_reference_t<Self>> operator++(this Self& self, std::integral auto /*idx*/) {
+    constexpr std::remove_cvref_t<Self> operator++(this Self& self, std::integral auto /*idx*/) {
         using Result = std::remove_cvref_t<Self>;
         Result result{self};
         ++self;
         return result;
     }
     template <typename Self>
-    constexpr std::add_const_t<std::remove_reference_t<Self>> operator--(this Self& self, std::integral auto /*idx*/) {
+    constexpr std::remove_cvref_t<Self> operator--(this Self& self, std::integral auto /*idx*/) {
         using Result = std::remove_cvref_t<Self>;
         Result result{self};
         --self;