Merge pull request #136 from alliander-opensource/feature/json-new-line

Add a new line to the end of compact json files

Author: TonyXiang8787

.github/workflows/main.yml

@@ -38,6 +38,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y ninja-build
+      - name: Enable brew
+        run: |
+          echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
       - name: Install C++ dependencies
         run: |
           brew install boost eigen nlohmann-json doctest

.github/workflows/sonar.yml

@@ -36,6 +36,9 @@ jobs:
         run: |
           sudo apt-get update
           sudo apt-get install -y ninja-build lcov gcovr
+      - name: Enable brew
+        run: |
+          echo "/home/linuxbrew/.linuxbrew/bin:/home/linuxbrew/.linuxbrew/sbin" >> $GITHUB_PATH
       - name: Install C++ dependencies
         run: |
           brew install boost eigen nlohmann-json doctest

src/power_grid_model/utils.py

@@ -553,4 +553,4 @@ def compact_json_dump(data: Any, io_stream: IO[str], indent: int, max_level: int
             io_stream.write("\n")
             compact_json_dump(obj, io_stream, indent, max_level, level + 2)
         io_stream.write(",\n" if i < n_obj else "\n")
-    io_stream.write(tab + "}")
+    io_stream.write(tab + "}\n")

tests/unit/test_utils.py

@@ -184,7 +184,8 @@ def test_compact_json_dump():
         == """{
   "node": [{"id": 1, "x": 2}, {"id": 3, "x": 4}],
   "line": [{"id": 5, "x": 6}, {"id": 7, "x": {"y": 8.1, "z": 8.2}}]
-}"""
+}
+"""
     )
 
     string_stream = io.StringIO()
@@ -196,7 +197,8 @@ def test_compact_json_dump():
     [{"id": 1, "x": 2}, {"id": 3, "x": 4}],
   "line":
     [{"id": 5, "x": 6}, {"id": 7, "x": {"y": 8.1, "z": 8.2}}]
-}"""
+}
+"""
     )
 
     string_stream = io.StringIO()
@@ -214,7 +216,8 @@ def test_compact_json_dump():
       {"id": 5, "x": 6},
       {"id": 7, "x": {"y": 8.1, "z": 8.2}}
     ]
-}"""
+}
+"""
     )
 
 
@@ -243,7 +246,9 @@ def test_compact_json_dump_deep():
       "x": 2,
       "y": 3
     }
-}"""
+
+}
+"""
     )
 
 
@@ -273,14 +278,16 @@ def test_compact_json_dump_batch():
         {"id": 5, "x": 6},
         {"id": 7, "x": {"y": 8.1, "z": 8.2}}
       ]
-  },
+  }
+,
   {
     "line":
       [
         {"id": 9, "x": 10},
         {"id": 11, "x": 12}
       ]
   }
+
 ]"""
     )