workaround compiler bug and address end()

Signed-off-by: Nitish Bharambe <[email protected]>

Author: nitbharambe

power_grid_model_c/power_grid_model/include/power_grid_model/container_fwd.hpp

@@ -10,15 +10,22 @@
 
 namespace power_grid_model::common {
 
-template <typename ContainerType, typename... RetrievableType>
-concept component_container_c = (requires(ContainerType const& c, ID id, Idx2D idx2d) {
+namespace detail {
+template <typename ContainerType, typename RetrievableType>
+concept single_component_container_c = requires(ContainerType const& c, ID id, Idx2D idx2d) {
     { c.template citer<RetrievableType>().begin() } -> std::forward_iterator;
     { c.template citer<RetrievableType>().end() } -> std::forward_iterator;
     { *(c.template citer<RetrievableType>().begin()) } -> std::same_as<RetrievableType const&>;
-    { *(c.template citer<RetrievableType>().end()) } -> std::same_as<RetrievableType const&>;
+    {
+        c.template citer<RetrievableType>().end()
+    } -> std::same_as<decltype(c.template citer<RetrievableType>().begin())>;
     { c.template get_item<RetrievableType>(id) } -> std::convertible_to<RetrievableType const&>;
     { c.template size<RetrievableType>() } -> std::same_as<Idx>;
     { c.template get_seq<RetrievableType>(idx2d) } -> std::same_as<Idx>;
-} && ...);
+};
+} // namespace detail
+
+template <typename ContainerType, typename... RetrievableType>
+concept component_container_c = (detail::single_component_container_c<ContainerType, RetrievableType> && ...);
 
 } // namespace power_grid_model::common