cleanup todos

Signed-off-by: Nitish Bharambe <[email protected]>

Author: nitbharambe

power_grid_model_c/power_grid_model/include/power_grid_model/container_fwd.hpp

@@ -41,9 +41,6 @@ concept storagable_single_component_container_c =
         { nc.template emplace<StoragableType>(id, args...) } -> std::same_as<void>;
     };
 
-// TODO This compound function is excluded from above concepts
-// { c.template get_start_idx<GettableBaseType, StoragableType>() } -> std::same_as<Idx>;
-
 } // namespace detail
 
 template <typename ContainerType, typename... RetrievableType>

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/container_queries.hpp

@@ -47,7 +47,7 @@ template <std::derived_from<Base> BaseComponent, std::derived_from<Base> Compone
     requires std::derived_from<Component, BaseComponent> &&
              common::component_container_c<ComponentContainer, BaseComponent> &&
              common::storagable_component_container_c<ComponentContainer, Component>
-constexpr Idx get_component_sequence_offset(ComponentContainer const& components) {
+constexpr auto get_component_sequence_offset(ComponentContainer const& components) {
     return components.template get_start_idx<BaseComponent, Component>();
 }
 

power_grid_model_c/power_grid_model/include/power_grid_model/main_core/update.hpp

@@ -161,7 +161,6 @@ check_update_independence(typename ModelType::ComponentContainer const& componen
 } // namespace independence
 namespace detail {
 
-// TODO change to components
 template <component_c Component, class ComponentContainer, std::ranges::viewable_range Elements,
           std::output_iterator<Idx2D> OutputIterator>
     requires common::component_container_c<ComponentContainer, Component>

power_grid_model_c/power_grid_model/include/power_grid_model/main_model_impl.hpp

@@ -287,13 +287,12 @@ class MainModelImpl<ExtraRetrievableTypes<ExtraRetrievableType...>, ComponentLis
     /*
     the the sequence indexer given an input array of ID's for a given component type
     */
-    // TODO change to components
     void get_indexer(std::string_view component_type, ID const* id_begin, Idx size, Idx* indexer_begin) const {
-        auto const get_index_func = [&state = this->state_, component_type, id_begin, size,
+        auto const get_index_func = [&components = this->state_.components, component_type, id_begin, size,
                                      indexer_begin]<typename CT>() {
             if (component_type == CT::name) {
-                std::transform(id_begin, id_begin + size, indexer_begin, [&state](ID id) {
-                    return main_core::get_component_idx_by_id<CT>(state.components, id).pos;
+                std::transform(id_begin, id_begin + size, indexer_begin, [&components](ID id) {
+                    return main_core::get_component_idx_by_id<CT>(components, id).pos;
                 });
             }
         };