resolve sonar cloud

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging.hpp

@@ -49,9 +49,6 @@ struct Logger {
     virtual void log(LogEvent tag, double value) = 0;
     virtual void log(LogEvent tag, Idx value) = 0;
 
-    // creates a new logger of the same type as the current one
-    virtual std::unique_ptr<Logger> clone() const = 0;
-
     virtual ~Logger() = default;
 };
 

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp

@@ -11,11 +11,10 @@
 
 namespace power_grid_model::common::logging {
 class NoLogger : public Logger {
-    void log(LogEvent /*tag*/) override {}
-    void log(LogEvent /*tag*/, std::string_view /*message*/) override {}
-    void log(LogEvent /*tag*/, double /*value*/) override {}
-    void log(LogEvent /*tag*/, Idx /*value*/) override {}
-    std::unique_ptr<Logger> clone() const override { return std::make_unique<NoLogger>(); }
+    virtual void log(LogEvent /*tag*/) override { /* no logging */ }
+    virtual void log(LogEvent /*tag*/, std::string_view /*message*/) override { /* no logging */ }
+    virtual void log(LogEvent /*tag*/, double /*value*/) override { /* no logging */ }
+    virtual void log(LogEvent /*tag*/, Idx /*value*/) override { /* no logging */ }
 };
 
 } // namespace power_grid_model::common::logging

power_grid_model_c/power_grid_model/include/power_grid_model/common/timer.hpp

@@ -55,7 +55,7 @@ class Timer {
         if (info_ != nullptr) {
             auto const now = Clock::now();
             auto const duration = Duration(now - start_);
-            info_->log(code_, static_cast<double>(duration.count()));
+            info_->log(code_, duration.count());
             info_ = nullptr;
         }
     }