Skip to content

Commit ad3c3eb

Browse files
committed
don't upgrade gcc just yet
Signed-off-by: Martijn Govers <[email protected]>
1 parent 05b59a5 commit ad3c3eb

File tree

4 files changed

+12
-18
lines changed

4 files changed

+12
-18
lines changed

.github/workflows/build-test-release.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -246,9 +246,6 @@ jobs:
246246
steps:
247247
- uses: actions/checkout@v5
248248

249-
- name: Export conda build
250-
run: echo "CONDA_BUILD=1" >> $GITHUB_ENV
251-
252249
- uses: conda-incubator/setup-miniconda@v3
253250
with:
254251
miniforge-version: latest # use miniforge instead of miniconda
@@ -262,9 +259,6 @@ jobs:
262259
run: |
263260
conda info
264261
conda list
265-
conda config --show-sources
266-
conda config --show
267-
printenv | sort
268262
269263
- uses: ./.github/actions/enable-msvc
270264
if: runner.os == 'Windows'

.github/workflows/check-code-quality.yml

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,6 @@ jobs:
2727
- name: Checkout
2828
uses: actions/checkout@v5
2929

30-
- name: Install packages
31-
run: |
32-
sudo apt-get update
33-
sudo apt-get install -y ninja-build gcc-14 g++-14
34-
sudo ln -s /usr/bin/gcc-14 /usr/local/bin/gcc
35-
sudo ln -s /usr/bin/g++-14 /usr/local/bin/g++
36-
3730
- name: Set up Python
3831
uses: actions/setup-python@v5
3932
with:
@@ -67,6 +60,7 @@ jobs:
6760
6861
- name: If needed raise error
6962
run: |
63+
7064
if [[ `git status --porcelain --untracked-files=no` ]]; then
7165
echo "Formatting not correct! See below the files which need to be reformatted!"
7266
git status --porcelain --untracked-files=no

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/y_bus.hpp

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,11 @@ struct YBusStructure {
261261
// end of y_bus_entry_indptr is same as size of entry
262262
assert(y_bus_entry_indptr.back() == static_cast<Idx>(y_bus_element.size()));
263263

264+
// construct transpose entry
265+
lu_transpose_entry.resize(nnz_counter_lu);
264266
// default transpose_entry[i] = i
265-
lu_transpose_entry = IdxRange{nnz_counter_lu} | std::ranges::to<IdxVector>();
267+
std::iota( // NOLINT(modernize-use-ranges) // not yet supported by some compilers
268+
lu_transpose_entry.begin(), lu_transpose_entry.end(), 0);
266269
// fill off-diagonal, loop all the branches
267270
for (auto const [entry_1, entry_2] : off_diag_map) {
268271
// for each branch entry tf and ft, they are transpose to each other

tests/cpp_unit_tests/test_dataset.cpp

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1067,12 +1067,15 @@ TEST_CASE_TEMPLATE("Test dataset (common)", DatasetType, ConstDataset, MutableDa
10671067
check_get_individual_scenario();
10681068
}
10691069
SUBCASE("columnar") {
1070-
auto a_id_buffer =
1071-
std::views::iota(0, a_elements_per_scenario * batch_size) | std::ranges::to<std::vector<ID>>();
1072-
auto a_a1_buffer =
1073-
std::views::iota(0, a_elements_per_scenario * batch_size) | std::ranges::to<std::vector<double>>();
1070+
auto a_id_buffer = std::vector<ID>(a_elements_per_scenario * batch_size);
1071+
auto a_a1_buffer = std::vector<double>(a_elements_per_scenario * batch_size);
10741072
auto b_indptr = std::vector<Idx>{0, 0, 3};
10751073

1074+
std::iota( // NOLINT(modernize-use-ranges) // not yet supported by some compilers
1075+
a_id_buffer.begin(), a_id_buffer.end(), ID{0});
1076+
std::iota( // NOLINT(modernize-use-ranges) // not yet supported by some compilers
1077+
a_a1_buffer.begin(), a_a1_buffer.end(), 0.0);
1078+
10761079
add_homogeneous_buffer(dataset, A::name, a_elements_per_scenario, nullptr);
10771080
add_attribute_buffer(dataset, A::name, "id", static_cast<void*>(a_id_buffer.data()));
10781081
add_attribute_buffer(dataset, A::name, "a1", static_cast<void*>(a_a1_buffer.data()));

0 commit comments

Comments
 (0)