Merge pull request #1136 from PowerGridModel/feature/full-observability-check-meshed-network-without-voltage-phasor

Observability: full observability check meshed network without voltage phasor

Author: Jerry-Jinfeng-Guo

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/iterative_linear_se_solver.hpp

@@ -99,7 +99,7 @@ template <symmetry_tag sym_type> class IterativeLinearSESolver {
         sub_timer = Timer{log, LogEvent::preprocess_measured_value};
         MeasuredValues<sym> const measured_values{y_bus.shared_topology(), input};
         auto const observability_result =
-            observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure());
+            observability::observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure());
 
         // prepare matrix
         sub_timer = Timer{log, LogEvent::prepare_matrix_including_prefactorization};

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/newton_raphson_se_solver.hpp

@@ -167,7 +167,7 @@ template <symmetry_tag sym_type> class NewtonRaphsonSESolver {
         sub_timer = Timer{log, LogEvent::preprocess_measured_value};
         MeasuredValues<sym> const measured_values{y_bus.shared_topology(), input};
         auto const observability_result =
-            observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure());
+            observability::observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure());
 
         // initialize voltage with initial angle
         sub_timer = Timer{log, LogEvent::initialize_voltages};

power_grid_model_c/power_grid_model/include/power_grid_model/math_solver/observability.hpp

@@ -20,12 +20,12 @@ void check_whether_observable(bool is_observable, MathModelTopology const& topo,
     math_solver::MeasuredValues<symmetric_t> const measured_values{y_bus.shared_topology(), se_input};
 
     if (is_observable) {
-        CHECK_NOTHROW(
-            math_solver::observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure()));
+        CHECK_NOTHROW(math_solver::observability::observability_check(measured_values, y_bus.math_topology(),
+                                                                      y_bus.y_bus_structure()));
     } else {
-        CHECK_THROWS_AS(
-            math_solver::observability_check(measured_values, y_bus.math_topology(), y_bus.y_bus_structure()),
-            NotObservableError);
+        CHECK_THROWS_AS(math_solver::observability::observability_check(measured_values, y_bus.math_topology(),
+                                                                        y_bus.y_bus_structure()),
+                        NotObservableError);
     }
 }
 

tests/cpp_unit_tests/test_observability.cpp

@@ -4,9 +4,5 @@
   "atol": {
     "default": 1e-8,
     ".+_residual": 5e-4
-  },
-  "xfail": {
-    "raises": "SparseMatrixError",
-    "reason": "Bug in Sparse LU solver found in #864"
   }
 }

tests/data/state_estimation/ill-conditioned-system/leaf-without-power-sensor-meshed/params.json

@@ -5,20 +5,15 @@
   "attributes": {},
   "data": {
     "node": [
-      {"id": 0, "energized": 1, "u_pu": 1, "u": 10, "u_angle": 0},
-      {"id": 1, "energized": 1, "u_pu": 0.9, "u": 9, "u_angle": 0}
+      {"id": 0, "u_pu": 1, "u": 10, "u_angle": 0},
+      {"id": 1, "u_pu": 0.9, "u": 9, "u_angle": 0},
+      {"id": 7, "u_pu": 0.95, "u": 9.5, "u_angle": 0}
     ],
     "source": [
-      {"id": 3, "energized": 1, "p": 10, "q": 0}
+      {"id": 3, "p": 10, "q": 0}
     ],
     "sym_load": [
-      {"id": 4, "energized": 1, "p": 9, "q": 0}
-    ],
-    "sym_power_sensor": [
-      {"id": 5, "energized": 1, "p_residual": 0, "q_residual": 0}
-    ],
-    "sym_voltage_sensor": [
-      {"id": 6, "energized": 1, "u_residual": 0}
+      {"id": 4, "p": 9, "q": 0}
     ]
   }
 }

tests/data/state_estimation/ill-conditioned-system/leaf-without-power-sensor-meshed/sym_output.json

@@ -8,8 +8,5 @@
   "raises": {
     "raises": "SparseMatrixError",
     "reason": "One nodal measurement can not be made use of."
-  },
-  "xpass": {
-    "reason": "Full observability check for meshed grids is not yet implemented. See also https://github.com/PowerGridModel/power-grid-model/issues/864."
   }
 }