Merge pull request #1084 from PowerGridModel/bug-fix/data-validator-trafo-cyclic-clock-align-behavior

Bug-fix: align data validator 2 and 3 winding trafo cyclic clock behavior

Author: Jerry-Jinfeng-Guo

src/power_grid_model/validation/_validation.py

@@ -672,8 +672,8 @@ def validate_three_winding_transformer(data: SingleDataset) -> list[ValidationEr
     errors += _all_valid_enum_values(data, ComponentType.three_winding_transformer, "winding_1", WindingType)
     errors += _all_valid_enum_values(data, ComponentType.three_winding_transformer, "winding_2", WindingType)
     errors += _all_valid_enum_values(data, ComponentType.three_winding_transformer, "winding_3", WindingType)
-    errors += _all_between_or_at(data, ComponentType.three_winding_transformer, "clock_12", 0, 12)
-    errors += _all_between_or_at(data, ComponentType.three_winding_transformer, "clock_13", 0, 12)
+    errors += _all_between_or_at(data, ComponentType.three_winding_transformer, "clock_12", -12, 12)
+    errors += _all_between_or_at(data, ComponentType.three_winding_transformer, "clock_13", -12, 12)
     errors += _all_valid_clocks(data, ComponentType.three_winding_transformer, "clock_12", "winding_1", "winding_2")
     errors += _all_valid_clocks(data, ComponentType.three_winding_transformer, "clock_13", "winding_1", "winding_3")
     errors += _all_valid_enum_values(data, ComponentType.three_winding_transformer, "tap_side", Branch3Side)

tests/unit/validation/test_input_validation.py

@@ -822,6 +822,10 @@ def test_validate_three_winding_transformer(input_data):
     assert NotGreaterOrEqualError(ComponentType.three_winding_transformer, "i0", [29], "p0/sn_1") in validation_errors
     assert NotLessThanError(ComponentType.three_winding_transformer, "i0", [28], 1) in validation_errors
     assert NotGreaterOrEqualError(ComponentType.three_winding_transformer, "p0", [1], 0) in validation_errors
+    assert (
+        NotBetweenOrAtError(ComponentType.three_winding_transformer, "clock_13", [1, 28], (-12, 12))
+        in validation_errors
+    )
     assert (
         NotBetweenOrAtError(ComponentType.three_winding_transformer, "tap_pos", [1, 28], ("tap_min", "tap_max"))
         in validation_errors

tests/unit/validation/test_validation_functions.py

@@ -1380,7 +1380,7 @@ def test_all_default_values():
     three_winding_transformer["winding_2"] = [1]
     three_winding_transformer["winding_3"] = [1]
     three_winding_transformer["clock_12"] = [5]
-    three_winding_transformer["clock_13"] = [5]
+    three_winding_transformer["clock_13"] = [-7]  # supports periodic clock input
     three_winding_transformer["tap_side"] = [0]
     three_winding_transformer["tap_min"] = [-10]
     three_winding_transformer["tap_max"] = [10]