Merge pull request #1129 from PowerGridModel/feature/sonar-cloud-warnings-3

Sonar cloud issues: resource management participation + if consteval

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/common.hpp

@@ -116,7 +116,7 @@ template <typename T> constexpr T map_to_cyclic_range(T value, T period) {
     if constexpr (std::is_integral_v<T>) {
         return static_cast<T>((value % period + period) % period);
     } else {
-        if (std::is_constant_evaluated()) {
+        if consteval {
             T quotient = value / period;
             Idx const floored_quotient =
                 (quotient >= T{0}) ? static_cast<Idx>(quotient) : static_cast<Idx>(quotient) - 1;

power_grid_model_c/power_grid_model/include/power_grid_model/common/multi_threaded_logging.hpp

@@ -20,10 +20,23 @@ class MultiThreadedLoggerImpl : public MultiThreadedLogger {
     class ThreadLogger : public LoggerType {
       public:
         ThreadLogger(MultiThreadedLoggerImpl& parent) : parent_{&parent} {}
-        ThreadLogger(ThreadLogger const&) = default;
-        ThreadLogger& operator=(ThreadLogger const&) = default;
-        ThreadLogger(ThreadLogger&&) noexcept = default;
-        ThreadLogger& operator=(ThreadLogger&&) noexcept = default;
+        ThreadLogger(ThreadLogger const& other) : LoggerType{other}, parent_{other.parent_} {};
+        ThreadLogger& operator=(ThreadLogger const& other) {
+            if (this != &other) {
+                LoggerType::operator=(other);
+                parent_ = other.parent_;
+            }
+            return *this;
+        };
+        ThreadLogger(ThreadLogger&& other) noexcept
+            : LoggerType{std::move(static_cast<LoggerType>(other))}, parent_{other.parent_} {};
+        ThreadLogger& operator=(ThreadLogger&& other) noexcept {
+            if (this != &other) {
+                parent_ = std::exchange(other.parent_, nullptr);
+                LoggerType::operator=(std::move(other));
+            }
+            return *this;
+        };
         ~ThreadLogger() noexcept override {
             try {
                 sync();

power_grid_model_c/power_grid_model/include/power_grid_model/common/timer.hpp

@@ -26,7 +26,8 @@ class Timer {
     Timer(Logger& log, LogEvent code) : log_{&log}, code_{code}, start_{Clock::now()} {}
 
     Timer(Timer const&) = delete;
-    Timer(Timer&&) = default;
+    Timer(Timer&& other) noexcept
+        : log_{std::exchange(other.log_, nullptr)}, code_{other.code_}, start_{other.start_} {}
     Timer& operator=(Timer const&) = delete;
 
     Timer& operator=(Timer&& timer) noexcept {