You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+4-4Lines changed: 4 additions & 4 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -15,7 +15,7 @@ There are just a few small guidelines you need to follow before making a change.
15
15
Contribution does not necessarily mean committing code to the repository.
16
16
We recognize different levels of contributions as shown below in increasing order of dedication:
17
17
18
-
1. Test and use the libray. Give feedback on the user experience or suggest new features.
18
+
1. Test and use the library. Give feedback on the user experience or suggest new features.
19
19
2. Validate the model against other existing libraries. Provide validation test cases.
20
20
3. Report bugs.
21
21
4. Improve the Python interface or helper functions.
@@ -90,7 +90,7 @@ git commit ... --no-verify
90
90
91
91
All the files in the repository need to be [REUSE compliant](https://reuse.software/).
92
92
We use the pipeline to automatically check this.
93
-
If there are files which are not complying, the pipeline will fail the pull request will be blocked.
93
+
If there are files which are not complying, the pipeline will fail and the pull request will be blocked.
94
94
95
95
96
96
## Git branching
@@ -126,7 +126,7 @@ There are other great tools out there to manage DCO signoffs for developers to m
126
126
* Git makes it easy to add this line to your commit messages. Make sure the `user.name` and `user.email` are set in your git configs. Use `-s` or `--signoff` to add the Signed-off-by line to the end of the commit message.
127
127
*[Github UI automatic signoff capabilities](https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/) for adding the signoff automatically to commits made with the GitHub browser UI. This one can only be activated by the github org or repo admin.
128
128
*[GitHub UI automatic signoff capabilities via custom plugin](https://github.com/scottrigby/dco-gh-ui) for adding the signoff automatically to commits made with the GitHub browser UI
129
-
* Additionally, it is possible to use shell scripting to automatically apply the sign-off. For an example for bash to be put into a .bashrc file, see [here](https://wiki.lfenergy.org/display/HOME/Contribution+and+Compliance+Guidelines+for+LF+Energy+Foundation+hosted+projects).
129
+
* Additionally, it is possible to use shell scripting to automatically apply the sign-off. For an example for bash to be put into a .bashrc file, see [here](https://wiki.lfenergy.org/display/HOME/Contribution+and+Compliance+Guidelines).
130
130
* Alternatively, you can add `prepare-commit-msg hook` in .git/hooks directory. For an example, see [here](https://github.com/Samsung/ONE-vscode/wiki/ONE-vscode-Developer's-Certificate-of-Origin).
131
131
132
132
## Code reviews
@@ -143,7 +143,7 @@ Contributions should be submitted as Github pull requests. See [Creating a pull
143
143
The process for a code change and pull request you should follow:
144
144
145
145
1. Create a topic branch in your local repository, following the naming format
146
-
"feature-###" or "fix-###". For more information see the Git branching guideline.
146
+
"feature/###" or "fix/###". For more information see the Git branching guideline.
147
147
1. Make changes, compile, and test thoroughly. Ensure any install or build dependencies are removed before the end of the layer when doing a build. Code style should match existing style and conventions, and changes should be focused on the topic the pull request will be addressed. For more information see the style guide.
148
148
1. Push commits to your fork.
149
149
1. Create a Github pull request from your topic branch.
0 commit comments