Skip to content

Commit dd649e6

Browse files
Merge pull request #124 from alliander-opensource/feature/open-doc-update
update open source documentation
2 parents 5a58f5d + b7023da commit dd649e6

File tree

3 files changed

+22
-7
lines changed

3 files changed

+22
-7
lines changed

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ There are just a few small guidelines you need to follow before making a change.
1515
Contribution does not necessarily mean committing code to the repository.
1616
We recognize different levels of contributions as shown below in increasing order of dedication:
1717

18-
1. Test and use the libray. Give feedback on the user experience or suggest new features.
18+
1. Test and use the library. Give feedback on the user experience or suggest new features.
1919
2. Validate the model against other existing libraries. Provide validation test cases.
2020
3. Report bugs.
2121
4. Improve the Python interface or helper functions.
@@ -90,7 +90,7 @@ git commit ... --no-verify
9090

9191
All the files in the repository need to be [REUSE compliant](https://reuse.software/).
9292
We use the pipeline to automatically check this.
93-
If there are files which are not complying, the pipeline will fail the pull request will be blocked.
93+
If there are files which are not complying, the pipeline will fail and the pull request will be blocked.
9494

9595

9696
## Git branching
@@ -126,7 +126,7 @@ There are other great tools out there to manage DCO signoffs for developers to m
126126
* Git makes it easy to add this line to your commit messages. Make sure the `user.name` and `user.email` are set in your git configs. Use `-s` or `--signoff` to add the Signed-off-by line to the end of the commit message.
127127
* [Github UI automatic signoff capabilities](https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/) for adding the signoff automatically to commits made with the GitHub browser UI. This one can only be activated by the github org or repo admin.
128128
* [GitHub UI automatic signoff capabilities via custom plugin]( https://github.com/scottrigby/dco-gh-ui ) for adding the signoff automatically to commits made with the GitHub browser UI
129-
* Additionally, it is possible to use shell scripting to automatically apply the sign-off. For an example for bash to be put into a .bashrc file, see [here](https://wiki.lfenergy.org/display/HOME/Contribution+and+Compliance+Guidelines+for+LF+Energy+Foundation+hosted+projects).
129+
* Additionally, it is possible to use shell scripting to automatically apply the sign-off. For an example for bash to be put into a .bashrc file, see [here](https://wiki.lfenergy.org/display/HOME/Contribution+and+Compliance+Guidelines).
130130
* Alternatively, you can add `prepare-commit-msg hook` in .git/hooks directory. For an example, see [here](https://github.com/Samsung/ONE-vscode/wiki/ONE-vscode-Developer's-Certificate-of-Origin).
131131

132132
## Code reviews
@@ -143,7 +143,7 @@ Contributions should be submitted as Github pull requests. See [Creating a pull
143143
The process for a code change and pull request you should follow:
144144

145145
1. Create a topic branch in your local repository, following the naming format
146-
"feature-###" or "fix-###". For more information see the Git branching guideline.
146+
"feature/###" or "fix/###". For more information see the Git branching guideline.
147147
1. Make changes, compile, and test thoroughly. Ensure any install or build dependencies are removed before the end of the layer when doing a build. Code style should match existing style and conventions, and changes should be focused on the topic the pull request will be addressed. For more information see the style guide.
148148
1. Push commits to your fork.
149149
1. Create a Github pull request from your topic branch.

README.md

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,9 +164,24 @@ Node Result
164164
1 2 1 0.994801 10445.415523 -0.003096
165165
```
166166

167+
# Folder Structure
168+
169+
The repository folder structure is as follows. The `examples`, `docs` and `scripts` are self-explanatory.
170+
171+
- The C++ calculation core is inside [include/power-grid-model](include/power-grid-model).
172+
- The python interface code is in [src/power_grid_model](src/power_grid_model)
173+
- The code for validation of input data is in [validation](src/power_grid_model/validation) folder.
174+
- The [tests](tests) folder is divided in the following way:
175+
- `cpp_unit_tests` contains the tests for the C++ calculation core.
176+
- `benchmark_cpp` contains a benchmark test case generator in C++.
177+
- `unit` folder contains tests for the python code.
178+
- `data` contains validation test cases designed for every component and algorithm. Some sample network types are also included.
179+
The validation is either against popular power system analysis software or hand calculation.
180+
167181
# Examples
168182

169-
Please refer to [Examples](examples) for more detailed examples for power flow and state estimation.
183+
Please refer to [Examples](examples) for more detailed examples for power flow and state estimation.
184+
Notebooks for validating the input data and exporting input/output data are also included.
170185

171186
# License
172187
This project is licensed under the Mozilla Public License, version 2.0 - see [LICENSE](LICENSE) for details.

RELEASE.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,12 +10,12 @@ This project uses a rolling release strategy on `main` branch.
1010
A new push(merge) to the `main` branch will trigger GitHub Actions to automatically
1111
build and upload a new version to PyPI with a unique version number.
1212

13-
**All the bug fixes will be commited directly into the `main` branch and published in the latest release.
13+
**All the bug fixes will be committed directly into the `main` branch and published in the latest release.
1414
No effort will be spent on backporting bug fixes to previous versions!**
1515

1616
Sometimes a `release/` branch will be created temporarily for
1717
a big new version with new features and/or breaking changes.
1818
A push(merge) to the release branch will tigger GitHub Actions to automatically
1919
build and upload a new version to PyPI with a unique release-candidate version number (suffix `rc`).
2020

21-
**NOTE: Release candicate versions are for testing only. You should not use them in production!**
21+
**NOTE: Release candidate versions are for testing only. You should not use them in production!**

0 commit comments

Comments
 (0)