public virtual destructor

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/calculation_info.hpp

@@ -10,7 +10,7 @@
 
 namespace power_grid_model {
 namespace common::logging {
-class CalculationInfo final: public Logger {
+class CalculationInfo final : public Logger {
     using Data = std::map<LogEvent, double>;
 
   public:
@@ -78,9 +78,8 @@ class CalculationInfo final: public Logger {
     }
     void accumulate_log(LogEvent tag, double value) { data_[tag] += value; }
     void maximize_log(LogEvent tag, double value) {
-        if (auto& stored_value = data_[tag]; value > stored_value) {
-            stored_value = value;
-        }
+        auto& stored_value = data_[tag];
+        stored_value = std::max(value, stored_value);
     }
 
   public:

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging.hpp

@@ -52,12 +52,12 @@ class Logger {
 
     Logger(Logger&&) noexcept = default;
     Logger& operator=(Logger&&) noexcept = default;
+    virtual ~Logger() = default;
 
   protected:
     Logger() = default;
     Logger(Logger const&) = default;
     Logger& operator=(Logger const&) = default;
-    virtual ~Logger() = default;
 };
 
 } // namespace common::logging