sonar cloud

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/calculation_info.hpp

@@ -17,8 +17,8 @@ class CalculationInfo : public NoLogger {
     using Report = std::add_lvalue_reference_t<std::add_const_t<Data>>;
     static_assert(std::same_as<Report, Data const&>);
 
-    void log(LogEvent tag, double value) override { log_impl(tag, value); }
-    void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
+    virtual void log(LogEvent tag, double value) override { log_impl(tag, value); }
+    virtual void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
 
   private:
     Data data_;

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp

@@ -11,10 +11,18 @@
 
 namespace power_grid_model::common::logging {
 class NoLogger : public Logger {
-    virtual void log(LogEvent /*tag*/) override { /* no logging */ }
-    virtual void log(LogEvent /*tag*/, std::string_view /*message*/) override { /* no logging */ }
-    virtual void log(LogEvent /*tag*/, double /*value*/) override { /* no logging */ }
-    virtual void log(LogEvent /*tag*/, Idx /*value*/) override { /* no logging */ }
+    void log(LogEvent /*tag*/) override {
+        // no logging
+    }
+    void log(LogEvent /*tag*/, std::string_view /*message*/) override {
+        // no logging
+    }
+    void log(LogEvent /*tag*/, double /*value*/) override {
+        // no logging
+    }
+    void log(LogEvent /*tag*/, Idx /*value*/) override {
+        // no logging
+    }
 };
 
 } // namespace power_grid_model::common::logging