fix compilation

Signed-off-by: Martijn Govers <[email protected]>

Author: mgovers

power_grid_model_c/power_grid_model/include/power_grid_model/common/calculation_info.hpp

@@ -10,20 +10,28 @@
 
 namespace power_grid_model {
 namespace common::logging {
-class CalculationInfo : public NoLogger {
+class CalculationInfo : public Logger {
     using Data = std::map<LogEvent, double>;
 
   public:
     using Report = std::add_lvalue_reference_t<std::add_const_t<Data>>;
     static_assert(std::same_as<Report, Data const&>);
 
-    void log(LogEvent tag, double value) override { log_impl(tag, value); }
-    void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
-    
+    CalculationInfo() = default;
     CalculationInfo(CalculationInfo const&) = default;
     CalculationInfo(CalculationInfo&&) noexcept = default;
     CalculationInfo& operator=(CalculationInfo const&) = default;
     CalculationInfo& operator=(CalculationInfo&&) noexcept = default;
+    ~CalculationInfo() = default;
+
+    void log(LogEvent tag) override {
+        // ignore all such events for now
+    }
+    void log(LogEvent tag, std::string_view /*message*/) override {
+        // ignore all such events for now
+    }
+    void log(LogEvent tag, double value) override { log_impl(tag, value); }
+    void log(LogEvent tag, Idx value) override { log_impl(tag, static_cast<double>(value)); }
 
   private:
     Data data_;

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging.hpp

@@ -49,13 +49,15 @@ class Logger {
     virtual void log(LogEvent tag, std::string_view message) = 0;
     virtual void log(LogEvent tag, double value) = 0;
     virtual void log(LogEvent tag, Idx value) = 0;
-    virtual ~Logger() = 0;
+
+    Logger(Logger&&) noexcept = default;
+    Logger& operator=(Logger&&) noexcept = default;
 
   protected:
+    Logger() = default;
     Logger(Logger const&) = default;
-    Logger(Logger&&) noexcept = default;
     Logger& operator=(Logger const&) = default;
-    Logger& operator=(Logger&&) noexcept = default;
+    virtual ~Logger() = default;
 };
 
 } // namespace common::logging

power_grid_model_c/power_grid_model/include/power_grid_model/common/logging_impl.hpp

@@ -24,11 +24,6 @@ class NoLogger : public Logger {
     void log(LogEvent /*tag*/, Idx /*value*/) override {
         // no logging
     }
-    NoLogger(NoLogger const&) = default;
-    NoLogger(NoLogger&&) noexcept = default;
-    NoLogger& operator=(NoLogger const&) = default;
-    NoLogger& operator=(NoLogger&&) noexcept = default;
-    ~NoLogger() override = default;
 };
 
 } // namespace power_grid_model::common::logging